fix regression tests. #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
stephenplusplus
force-pushed
the
spp--regression-test-fixes
branch
from
0105339 to
32b7c25
Compare
Closed
Contributor
|
Yay! Can you write a comment here so that developers know that deleting a topic will destroy all subscriptions for that topic? |
Contributor
Author
|
👍 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
LGTM! 🚂 Here goes! |
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/e2b098f4-76c4-4fe5-820c-ae293231f7bd/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@0c868d4
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 15, 2022
* changes without context
autosynth cannot find the source of changes triggered by earlier changes in this
repository, or by version upgrades to tools such as linters.
* chore(nodejs_templates): add script logging to node_library populate-secrets.sh
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Source-Author: BenWhitehead <BenWhitehead@users.noreply.github.com>
Source-Date: Wed Jun 10 22:24:28 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: e7034945fbdc0e79d3c57f6e299e5c90b0f11469
Source-Link: googleapis/synthtool@e703494
Merged
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 16, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [3.1.3](https://www.github.com/googleapis/nodejs-os-login/compare/v3.1.2...v3.1.3) (2020-11-25) ### Bug Fixes * check for fetch on window ([#401](https://www.github.com/googleapis/nodejs-os-login/issues/401)) ([e2547a9](https://www.github.com/googleapis/nodejs-os-login/commit/e2547a90031a46a4ad044318c26c160d8fb04ff6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
sofisl
pushed a commit
that referenced
this pull request
Sep 27, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [3.1.3](https://www.github.com/googleapis/nodejs-os-login/compare/v3.1.2...v3.1.3) (2020-11-25) ### Bug Fixes * check for fetch on window ([#401](https://www.github.com/googleapis/nodejs-os-login/issues/401)) ([e2547a9](https://www.github.com/googleapis/nodejs-os-login/commit/e2547a90031a46a4ad044318c26c160d8fb04ff6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [3.1.3](https://www.github.com/googleapis/nodejs-os-login/compare/v3.1.2...v3.1.3) (2020-11-25) ### Bug Fixes * check for fetch on window ([#401](https://www.github.com/googleapis/nodejs-os-login/issues/401)) ([e2547a9](https://www.github.com/googleapis/nodejs-os-login/commit/e2547a90031a46a4ad044318c26c160d8fb04ff6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
GautamSharda
pushed a commit
that referenced
this pull request
Jan 20, 2026
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 21, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 21, 2026
4 tasks
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
This was referenced Jan 27, 2026
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
This was referenced Jan 27, 2026
sofisl
pushed a commit
that referenced
this pull request
Jan 28, 2026
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 28, 2026
This was referenced Jan 29, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Feb 2, 2026
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our merge of #388 didn't end up helping our regression tests. Well, it may have, but it seems a new one has popped up.
When I run locally, I don't get the error, but Travis does. It gets an error in one of the many functions being called in a
beforehook. So, I started looking deeper into what the troubled hook does, and questioned what was necessary so that it could be uncomplicated.This PR includes my findings.