fix (regression tests): make datastore queries strongly consistent #267

silvolu · 2014-10-23T20:48:43Z

The previous tests were flaky because based on eventually consistent queries.
The new tests use only ancestor queries, that are strongly consistent.

regression/datastore.js

-  describe('querying the datastore', function() {
+  describe.only('querying the datastore', function() {
+
+    var ancestor = ['Book', 'GoT'];


The previous tests were flaky because based on eventually consistent queries. The new tests use only ancestor queries, that are strongly consistent.

silvolu · 2014-10-23T21:00:20Z

Done (squashed to avoid leaving traces of my bad commits :) )

ryanseys · 2014-10-23T21:02:03Z

Perfect! Thanks! Merging.

PS: Github knows. 👀

ryanseys · 2014-10-23T21:02:29Z

... will merge after tests run ...

fix (regression tests): make datastore queries strongly consistent

Integrates changes from googleapis/google-cloud-node#267

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

* fix(docs): reference docs should link to section of googleapis.dev with API reference * fix(docs): make anchors work in jsdoc

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

* updated CHANGELOG.md * updated package.json * updated samples/package.json

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [3.0.1](https://www.github.com/googleapis/nodejs-containeranalysis/compare/v3.0.0...v3.0.1) (2020-11-25) ### Bug Fixes * **browser:** check for fetch on window ([#267](https://www.github.com/googleapis/nodejs-containeranalysis/issues/267)) ([003a128](https://www.github.com/googleapis/nodejs-containeranalysis/commit/003a128f84f0a7cdcff34ba77dc60d88a4d7969b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

@joonlim

…quire approval before executing and ApproveBuild API to approve or reject pending Builds (#267) Comitter: @joonlim PiperOrigin-RevId: 391072303 Source-Link: googleapis/googleapis@7fec729 Source-Link: googleapis/googleapis-gen@22f5dc3

🤖 I have created a release \*beep\* \*boop\* --- ## [2.4.0](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v2.3.2...v2.4.0) (2021-08-16) ### Features * Add ability to configure BuildTriggers to create Builds that require approval before executing and ApproveBuild API to approve or reject pending Builds ([#267](https://www.github.com/googleapis/nodejs-cloudbuild/issues/267)) ([18ec067](https://www.github.com/googleapis/nodejs-cloudbuild/commit/18ec067ac1e112836c5d56747dda89e04f87c481)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* chore(main): release 3.0.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sinon](https://sinonjs.org/) ([source](https://togithub.com/sinonjs/sinon)) | [`^13.0.0` -> `^14.0.0`](https://renovatebot.com/diffs/npm/sinon/13.0.2/14.0.0) | [![age](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/compatibility-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/confidence-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sinonjs/sinon</summary> ### [`v14.0.0`](https://togithub.com/sinonjs/sinon/blob/HEAD/CHANGES.md#1400) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v13.0.2...v14.0.0) - [`c2bbd826`](https://togithub.com/sinonjs/sinon/commit/c2bbd82641444eb5b32822489ae40f185afbbf00) Drop node 12 (Morgan Roderick) > And embrace Node 18 > > See https://nodejs.org/en/about/releases/ *Released by Morgan Roderick on 2022-05-07.* </details> --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-dialogflow-cx).

PiperOrigin-RevId: 429098186 Source-Link: googleapis/googleapis@e75c527 Source-Link: googleapis/googleapis-gen@6114713 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjExNDcxMzMzODE4Zjg4ZjY2YmZlMjRhYzk3ZDIwNjRjZTBiNTJhZCJ9

* updated CHANGELOG.md * updated package.json * updated samples/package.json

stephenplusplus added the in progress label Oct 23, 2014

ryanseys reviewed Oct 23, 2014
View reviewed changes

regression/datastore.js

describe('querying the datastore', function() {

describe.only('querying the datastore', function() {

var ancestor = ['Book', 'GoT'];

This comment was marked as spam.

Sign in to view

fix (regression tests): make datastore queries strongly consistent

e633edf

The previous tests were flaky because based on eventually consistent queries. The new tests use only ancestor queries, that are strongly consistent.

silvolu force-pushed the fix-datastore-regression branch from b057b5b to e633edf Compare October 23, 2014 20:59

ryanseys added a commit that referenced this pull request Oct 23, 2014

Merge pull request #267 from silvolu/fix-datastore-regression

51abc0d

fix (regression tests): make datastore queries strongly consistent

ryanseys merged commit 51abc0d into googleapis:master Oct 23, 2014

stephenplusplus removed the in progress label Oct 23, 2014

dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Oct 23, 2014

Using ancestor queries for strong consistency.

81f3b0c

Integrates changes from googleapis/google-cloud-node#267

dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Oct 23, 2014

Using ancestor queries for strong consistency.

592b1ba

Integrates changes from googleapis/google-cloud-node#267

dhermes mentioned this pull request Oct 23, 2014

Functional test - Add datastore query tests googleapis/google-cloud-python#281

Merged

sofisl mentioned this pull request Sep 16, 2022

migrate code from googleapis/nodejs-os-login #3366

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 16, 2022

chore(deps): update dependency mocha to v7 (#267)

76315e3

sofisl pushed a commit that referenced this pull request Sep 27, 2022

chore: release 2.2.1 (#267)

4de51ab

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

sofisl mentioned this pull request Sep 27, 2022

migrate code from googleapis/nodejs-video-intelligence #3374

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 5, 2022

chore(deps): update dependency mocha to v7 (#267)

3c34a21

sofisl mentioned this pull request Oct 5, 2022

migrate code from googleapis/nodejs-os-login #3388

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 5, 2022

chore(deps): update dependency mocha to v7 (#267)

2fee815

sofisl mentioned this pull request Oct 8, 2022

migrate code from googleapis/nodejs-os-login #3389

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 8, 2022

chore(deps): update dependency mocha to v7 (#267)

7cd2b4b

This was referenced Oct 11, 2022

migrate code from googleapis/nodejs-os-login #3391

Merged

migrate code from googleapis/nodejs-language #3395

Merged

sofisl pushed a commit that referenced this pull request Oct 11, 2022

fix(docs): link to reference docs section on googleapis.dev (#267)

cac9e84

* fix(docs): reference docs should link to section of googleapis.dev with API reference * fix(docs): make anchors work in jsdoc

sofisl pushed a commit that referenced this pull request Oct 12, 2022

build: use c8 for coverage (#267)

f5edce1

sofisl mentioned this pull request Oct 12, 2022

migrate code from googleapis/nodejs-resource-manager #3402

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 13, 2022

fix(docs): link to reference docs section on googleapis.dev (#267)

6dd9dfd

* fix(docs): reference docs should link to section of googleapis.dev with API reference * fix(docs): make anchors work in jsdoc

sofisl pushed a commit that referenced this pull request Nov 9, 2022

chore: release 2.2.1 (#267)

ac2d5a7

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-video-intelligence #3519

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 10, 2022

fix(deps): update dependency @google-cloud/automl to v1 (#267)

5b29d56

This was referenced Nov 10, 2022

migrate code from googleapis/nodejs-translate #3520

Merged

migrate code from googleapis/nodejs-monitoring #3545

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore: release 1.2.0 (#267)

39a0ff7

* updated CHANGELOG.md * updated package.json * updated samples/package.json

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-dialogflow #3546

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

Release v0.8.1 (#267)

4c60629

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-scheduler #3547

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

build: use bazel build (#267)

ce89aeb

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore: release 2.1.6 (#267)

f7a9ebb

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-web-risk #3549

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

fix(browser): check for fetch on window (#267)

308506e

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-containeranalysis #3550

Merged

migrate code from googleapis/nodejs-cloudbuild #3566

Merged

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-game-servers #3569

Merged

migrate code from googleapis/nodejs-dialogflow-cx #3602

Merged

sofisl pushed a commit that referenced this pull request Nov 17, 2022

fix(deps): update dependency @google-cloud/promisify to ^0.4.0 (#267)

b8a94a3

sofisl mentioned this pull request Nov 17, 2022

migrate code from googleapis/nodejs-compute #3666

Merged

4 tasks

sofisl mentioned this pull request Jan 26, 2023

migrate code from googleapis/nodejs-ai-platform #3892

Merged

4 tasks

sofisl mentioned this pull request Sep 13, 2023

migrate code from googleapis/nodejs-automl #4655

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 13, 2023

fix(docs): snippets are now replaced in jsdoc comments (#267)

883ce5a

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-automl #4656

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 14, 2023

chore: release 1.0.1 (#267)

197456a

* updated CHANGELOG.md * updated package.json * updated samples/package.json

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix (regression tests): make datastore queries strongly consistent #267

fix (regression tests): make datastore queries strongly consistent #267

silvolu commented Oct 23, 2014

This comment was marked as spam.

silvolu commented Oct 23, 2014

ryanseys commented Oct 23, 2014

ryanseys commented Oct 23, 2014

fix (regression tests): make datastore queries strongly consistent #267

fix (regression tests): make datastore queries strongly consistent #267

Conversation

silvolu commented Oct 23, 2014

This comment was marked as spam.

silvolu commented Oct 23, 2014

ryanseys commented Oct 23, 2014

ryanseys commented Oct 23, 2014