Export trace key in logging-{winston,bunyan}#2602
Merged
stephenplusplus merged 2 commits intogoogleapis:masterfrom Sep 13, 2017
draffensperger:export-logging-key
Merged
Export trace key in logging-{winston,bunyan}#2602stephenplusplus merged 2 commits intogoogleapis:masterfrom draffensperger:export-logging-key
stephenplusplus merged 2 commits intogoogleapis:masterfrom
draffensperger:export-logging-key
Conversation
googlebot
added
the
cla: yes
ofrobots
approved these changes
Sep 11, 2017
| const recordWithTrace = extend({ | ||
| 'logging.googleapis.com/trace': 'projects/project1/traces/trace1' | ||
| }, RECORD); | ||
| var recordWithTrace = extend({}, RECORD); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
Is this good to merge? @stephenplusplus, did you want to take a look? |
Contributor
|
Sorry I didn't catch this one. LGTM! |
stephenplusplus
pushed a commit
to lukesneeringer/google-cloud-node
that referenced
this pull request
Sep 18, 2017
* Export trace key in logging-{winston,bunyan}
* Fix var to const
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 14, 2026
* Export trace key in logging-{winston,bunyan}
* Fix var to const
This was referenced Jan 14, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
* Export trace key in logging-{winston,bunyan}
* Fix var to const
GautamSharda
pushed a commit
that referenced
this pull request
Jan 20, 2026
* Export trace key in logging-{winston,bunyan}
* Fix var to const
4 tasks
GautamSharda
pushed a commit
that referenced
this pull request
Feb 3, 2026
* Export trace key in logging-{winston,bunyan}
* Fix var to const
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Feb 4, 2026
* Export trace key in logging-{winston,bunyan}
* Fix var to const
This was referenced Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the LOGGING_TRACE_KEY constant exported by the logging-{winston,bunyan} modules per conversation here: #2574 (comment)