Add errors system-test to system-test run

[cristiancavalli]

TODOS:

• Update env.js with new fields
• Add relevant values to process for CI run for env.js
  • Circle
  • AppVeyor
• Update errors system-test to use env.js file
• Make sure error reporting is enabled on CI project

[cristiancavalli]

@stephenplusplus @callmehiphop Is there anyway we could plant the newly added env values into the CI?

Currently the test wants two values:

• The project number which can be used interchangeably for the project id
• A valid API-key for the project instructions for which can be found here

I can also eliminate these e2e test variants if you feel this functionality is better tested elsewhere

[stephenplusplus]

I've added the number and API key to Circle-- I don't have access to the settings on AppVeyor

@lukesneeringer -- can you add an env var to AppVeyor, GCLOUD_TESTS_PROJECT_NUMBER set to REDACTED? I believe GCLOUD_TESTS_API_KEY is set, but if not, let me know.

@cristiancavalli can you add these env vars to https://github.com/GoogleCloudPlatform/google-cloud-node/blob/master/.github/CONTRIBUTING.md and also make them optional-- i.e. the describe block will be skipped if the env vars aren't set, something like:

var PROJECT_NUMBER = process.env.GCLOUD_TESTS_PROJECT_NUMBER;
var API_KEY = process.env.GCLOUD_TESTS_API_KEY;

var SHOULD_RUN = PROJECT_NUMBER && API_KEY;

(SHOULD_RUN ? describe : describe.skip)('error-reporting', function() {
  // ...
});

[cristiancavalli]

@lukesneeringer assigning you as well because of the necessary appveyor changes

[coveralls]

Changes Unknown when pulling ef0635c on integrate-errors-system-test into ** on master**.

[stephenplusplus]

Just an edit to CONTRIBUTING.md (https://github.com/GoogleCloudPlatform/google-cloud-node/blob/master/.github/CONTRIBUTING.md) to add the new ENV var in would be 👍

[cristiancavalli]

@lukesneeringer

[ofrobots]

@lukesneeringer @stephenplusplus It would be good move forward on this and #2208 so that we can get the error-reporting module published in time for the upcoming beta.

[lukesneeringer]

Sorry.

I added the project number to AppVeyor. The key is not set, so you will need to send it to me privately to set.

[lukesneeringer]

Both environment variables are now set in AppVeyor.

[stephenplusplus]

Tested locally with the system test credentials and all went well. Thanks @cristiancavalli! I'll merge after the new info is in CONTRIBUTING.md.

[stephenplusplus]

Just need edits to explain the new env vars in CONTRIBUTING.md.

[cristiancavalli]

@stephenplusplus Not sure why it's not showing up in the diff, if you pull from the branch it has the edit to contributing.md

[stephenplusplus]

Could that be coming from #2208? I see the edit over in that PR.

[cristiancavalli]

Just pushed more changes to this branch on CONTRIBUTING, they don't seem to be propagating over..

[stephenplusplus]

My faith in any code I've ever reviewed is shaken!

[cristiancavalli]

So weird, let me try reopeneing it

[stephenplusplus]

GitHub has been known to be behind on things like emails and commit logs. Haven't seen this issue before. After some long-running things are done in my terminal, I'll clone and check it out. I noticed it's not on the branch either when browsing the tree on GH.

[stephenplusplus]

That file is not edited in my checked out branch either.

[cristiancavalli]

hey @stephenplusplus my bad -- had the a different source repo checked out. Value should be updated in CONTRIBUTING -- please lmk if the copy should be worded differently

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

[stephenplusplus]

There it is! I simplified it a bunch just to be a little more future-proof (not listing the APIs that need them). Merge time!

[coveralls]

Changes Unknown when pulling 04a249b on integrate-errors-system-test into ** on master**.