Skip to content

logging-bunyan: default removeCircular to true#2094

Merged
stephenplusplus merged 1 commit intogoogleapis:masterfrom
ofrobots:bunyan-winston-circular
Mar 16, 2017
Merged

logging-bunyan: default removeCircular to true#2094
stephenplusplus merged 1 commit intogoogleapis:masterfrom
ofrobots:bunyan-winston-circular

Conversation

@ofrobots
Copy link
Contributor

Fixes: #1987

winston doesn't have this issue as objects will get formatted with util.inspect which will naturally removes circularity.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 16, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.924% when pulling b1bcf78 on ofrobots:bunyan-winston-circular into 402c534 on GoogleCloudPlatform:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants