Skip to content

storage: privatize makeReq #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rakyll merged 1 commit into from
Sep 9, 2014
Merged

storage: privatize makeReq #199

rakyll merged 1 commit into from
Sep 9, 2014

Conversation

@stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Sep 9, 2014

This was brought up some time ago, but I'll never be able to find where.

rakyll pushed a commit that referenced this pull request Sep 9, 2014
Merge pull request #199 from stephenplusplus/hide-makereq
ffa60ee 
storage: privatize `makeReq`
@rakyll rakyll merged commit ffa60ee into googleapis:master Sep 9, 2014
@rakyll
Copy link
Contributor

rakyll commented Sep 9, 2014

Oh, thanks :)

@ryanseys
Copy link
Contributor

ryanseys commented Sep 9, 2014

Yeah I think I recall bringing this up sometime ago. I have no idea where either. 😎

@sofisl sofisl mentioned this pull request Sep 16, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Sep 16, 2022
@yoshi-automation @JustinBeckwith
refactor: drop dependency on lodash.merge and update links (#199)
0a5272e
sofisl pushed a commit that referenced this pull request Sep 27, 2022
@jkwlui
Release v1.6.0 (#199)
253d8d1
@sofisl sofisl mentioned this pull request Sep 27, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Oct 5, 2022
@yoshi-automation @JustinBeckwith
refactor: drop dependency on lodash.merge and update links (#199)
0b380ac
@sofisl sofisl mentioned this pull request Oct 5, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Oct 5, 2022
@yoshi-automation @JustinBeckwith
refactor: drop dependency on lodash.merge and update links (#199)
13f7502
@sofisl sofisl mentioned this pull request Oct 8, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Oct 8, 2022
@yoshi-automation @JustinBeckwith
refactor: drop dependency on lodash.merge and update links (#199)
5c007f2
This was referenced Oct 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this pull request Oct 11, 2022
@jkwlui @callmehiphop
chore: move CONTRIBUTING.md to root (#199)
3932e43
sofisl pushed a commit that referenced this pull request Oct 12, 2022
@callmehiphop @JustinBeckwith
fix(deps): remove teeny-request as dependency (#199)
2d2f1e5
This was referenced Oct 12, 2022
Merged
Merged
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@gcf-owl-bot
fix: Updating WORKSPACE files to use the newest version of the Typesc…
14af07d 
…ript generator. (#199)

Also removing the explicit generator tag for the IAMPolicy mixin for the kms and pubsub APIS as the generator will now read it from the .yaml file.

PiperOrigin-RevId: 385101839

Source-Link: googleapis/googleapis@80f4042

Source-Link: googleapis/googleapis-gen@d3509d2
@sofisl sofisl mentioned this pull request Oct 13, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@renovate-bot
chore(deps): update dependency jsdoc-fresh to v2 (#199)
ae33c79 
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [jsdoc-fresh](https://togithub.com/googleapis/jsdoc-fresh) | [`^1.0.2` -> `^2.0.0`](https://renovatebot.com/diffs/npm/jsdoc-fresh/1.1.1/2.0.0) | [![age](https://badges.renovateapi.com/packages/npm/jsdoc-fresh/2.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/jsdoc-fresh/2.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/jsdoc-fresh/2.0.0/compatibility-slim/1.1.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/jsdoc-fresh/2.0.0/confidence-slim/1.1.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/jsdoc-fresh</summary>

### [`v2.0.0`](https://togithub.com/googleapis/jsdoc-fresh/blob/HEAD/CHANGELOG.md#&#8203;200-httpsgithubcomgoogleapisjsdoc-freshcomparev111v200-2022-05-18)

[Compare Source](https://togithub.com/googleapis/jsdoc-fresh/compare/v1.1.1...v2.0.0)

##### ⚠ BREAKING CHANGES

-   update library to use Node 12 ([#&#8203;108](https://togithub.com/googleapis/jsdoc-fresh/issues/108))

##### Build System

-   update library to use Node 12 ([#&#8203;108](https://togithub.com/googleapis/jsdoc-fresh/issues/108)) ([e61c223](https://togithub.com/googleapis/jsdoc-fresh/commit/e61c2238db8900e339e5fe7fb8aea09642290182))

##### [1.1.1](https://www.github.com/googleapis/jsdoc-fresh/compare/v1.1.0...v1.1.1) (2021-08-11)

##### Bug Fixes

-   **build:** migrate to using main branch ([#&#8203;83](https://www.togithub.com/googleapis/jsdoc-fresh/issues/83)) ([9474adb](https://www.github.com/googleapis/jsdoc-fresh/commit/9474adbf0d559d319ff207397ba2be6b557999ac))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-memcache).
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@jkwlui @sofisl
chore: move CONTRIBUTING.md to root (#199)
dbec10f
sofisl pushed a commit that referenced this pull request Nov 9, 2022
@jkwlui
Release v1.6.0 (#199)
c997575
This was referenced Nov 9, 2022
Closed
Merged
sofisl pushed a commit that referenced this pull request Nov 10, 2022
@JustinBeckwith
refactor: modernize sample tests (#199)
8fd4b9e
@sofisl sofisl mentioned this pull request Nov 10, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 10, 2022
@averikitsch @JustinBeckwith
docs(samples): Add HTTP Push Queue Sample (#199)
4b0af26
sofisl pushed a commit that referenced this pull request Sep 13, 2023
@yoshi-automation @JustinBeckwith
chore: release 1.2.1 (#199)
98e2208 
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
@sofisl sofisl mentioned this pull request Sep 14, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Sep 14, 2023
@JustinBeckwith
refactor: modernize the sample tests (#199)
6e3d5ef
@sofisl sofisl mentioned this pull request Sep 14, 2023
Merged
4 tasks
@takeratta takeratta mentioned this pull request Oct 27, 2023
Open
@takeratta takeratta mentioned this pull request Dec 14, 2023
Open
This was referenced Jan 2, 2024
Open
Open
@takeratta takeratta mentioned this pull request Mar 16, 2024
Open
@miguelvelezsa miguelvelezsa mentioned this pull request Jan 14, 2026
Closed
miguelvelezsa pushed a commit that referenced this pull request Jan 14, 2026
@JustinBeckwith
chore: drop contributors from multiple places (#199)
b419347
@miguelvelezsa miguelvelezsa mentioned this pull request Jan 14, 2026
Closed
GautamSharda pushed a commit that referenced this pull request Jan 14, 2026
@JustinBeckwith
test: fix a node 10 test failure (#199)
d7050a2
GautamSharda pushed a commit that referenced this pull request Jan 14, 2026
@jmdobry
Slight refactor of logging samples. (#199)
2fe6693
GautamSharda pushed a commit that referenced this pull request Jan 15, 2026
@JustinBeckwith
test: fix a node 10 test failure (#199)
8fbfcdd
GautamSharda pushed a commit that referenced this pull request Jan 20, 2026
@jmdobry
Slight refactor of logging samples. (#199)
dc7ef8d
@GautamSharda GautamSharda mentioned this pull request Jan 20, 2026
Closed
4 tasks
miguelvelezsa pushed a commit that referenced this pull request Jan 21, 2026
@JustinBeckwith
chore: drop contributors from multiple places (#199)
0cfd6a3
@miguelvelezsa miguelvelezsa mentioned this pull request Jan 21, 2026
Closed
GautamSharda pushed a commit that referenced this pull request Jan 21, 2026
@jmdobry
Slight refactor of logging samples. (#199)
d687f6b
@GautamSharda GautamSharda mentioned this pull request Jan 21, 2026
Closed
4 tasks
miguelvelezsa pushed a commit that referenced this pull request Jan 28, 2026
@dpebot @JustinBeckwith
Update the kokoro config (#199)
e1f4105
@miguelvelezsa miguelvelezsa mentioned this pull request Jan 28, 2026
Closed
miguelvelezsa pushed a commit that referenced this pull request Jan 29, 2026
@yoshi-automation
chore: linting rules (#199)
f4f9d24 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/d5e01c0b-0d2d-4da4-b495-86674ea6021f/targets
@miguelvelezsa miguelvelezsa mentioned this pull request Jan 29, 2026
Closed
GautamSharda pushed a commit that referenced this pull request Feb 2, 2026
@jkwlui @JustinBeckwith
build: run tests on node11 (#199)
9cc6f8c 
* build: run tests on node11

* build: run tests on node11

* build: run tests on node11

* build: run tests on node11
@GautamSharda GautamSharda mentioned this pull request Feb 2, 2026
Closed
GautamSharda pushed a commit that referenced this pull request Feb 3, 2026
@jmdobry
Slight refactor of logging samples. (#199)
4c3f886
GautamSharda pushed a commit that referenced this pull request Feb 3, 2026
@jkwlui @JustinBeckwith
build: run tests on node11 (#199)
c310edc 
* build: run tests on node11

* build: run tests on node11

* build: run tests on node11

* build: run tests on node11
@GautamSharda GautamSharda mentioned this pull request Feb 3, 2026
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephenplusplus @rakyll @ryanseys