datastore: expose ID, path, & namespace. fixes #171. #175

stephenplusplus · 2014-09-04T21:37:08Z

No description provided.

lib/datastore/entity.js

+        };
+        return acc;
+      }.bind(this), {})
+  );


lib/datastore/entity.js

+ *
+ * // key.id = 123
+ * // key.namespace = 'ns'
+ * // key.path = ['Company', 123]


stephenplusplus · 2014-09-05T17:38:05Z

Instead of all of this, how about just remove the _ from the constructor's this.namespace_ and this.path_?

stephenplusplus · 2014-09-05T18:57:48Z

We can drop this PR in favor of stephenplusplus@9667465 if we don't see ourselves needing to re-assign path or namespace.

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.4](https://www.github.com/googleapis/nodejs-media-translation/compare/v2.3.3...v2.3.4) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#174](https://www.github.com/googleapis/nodejs-media-translation/issues/174)) ([b90cf10](https://www.github.com/googleapis/nodejs-media-translation/commit/b90cf1034235ab0416011de7a1b77afed5597dfc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

) PiperOrigin-RevId: 459309277 Source-Link: googleapis/googleapis@2844793 Source-Link: googleapis/googleapis-gen@319987c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzE5OTg3Y2MwZTg3ODlhMzY4ZTM0ODgyMjcxYTkyYjA3MTdjOWM4ZiJ9 See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

samples: pull in latest typeless bot, clean up some comments Source-Link: https://togithub.com/googleapis/synthtool/commit/0a68e568b6911b60bb6fd452eba4848b176031d8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:5b05f26103855c3a15433141389c478d1d3fe088fb5d4e3217c4793f6b3f245e

@summer-ji-eng

[PR](googleapis/gapic-generator-typescript#878) within updated gapic-generator-typescript version 1.4.0 Committer: @summer-ji-eng PiperOrigin-RevId: 375759421 Source-Link: googleapis/googleapis@95fa72f Source-Link: googleapis/googleapis-gen@f40a343

🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.3](https://www.github.com/googleapis/nodejs-game-servers/compare/v2.3.2...v2.3.3) (2021-06-10) ### Bug Fixes * GoogleAdsError missing using generator version after 1.3.0 ([#175](https://www.github.com/googleapis/nodejs-game-servers/issues/175)) ([a0df035](https://www.github.com/googleapis/nodejs-game-servers/commit/a0df03530d0dc438c8c4318854fbcfa8d7752f8d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* feat!: Update library to use Node 12 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

samples: pull in latest typeless bot, clean up some comments Source-Link: https://togithub.com/googleapis/synthtool/commit/0a68e568b6911b60bb6fd452eba4848b176031d8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:5b05f26103855c3a15433141389c478d1d3fe088fb5d4e3217c4793f6b3f245e

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/mocha](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^8.0.4` -> `^9.0.0`](https://renovatebot.com/diffs/npm/@types%2fmocha/8.2.3/9.1.1) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/compatibility-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/confidence-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-retail).

…DME (#175)

datastore: expose ID, path, & namespace. fixes googleapis#171.

9147af7

stephenplusplus reviewed Sep 4, 2014
View reviewed changes

lib/datastore/entity.js

};

return acc;

}.bind(this), {})

);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

stephenplusplus mentioned this pull request Sep 4, 2014

datatstore: Provide a way to get the generated ID from a Key object #171

Closed

rakyll reviewed Sep 4, 2014
View reviewed changes

lib/datastore/entity.js

*

* // key.id = 123

* // key.namespace = 'ns'

* // key.path = ['Company', 123]

This comment was marked as spam.

Sign in to view

stephenplusplus closed this Sep 6, 2014

stephenplusplus mentioned this pull request Sep 6, 2014

datastore: refactor privatizing of Key values. #190

Merged

stephenplusplus mentioned this pull request Mar 2, 2015

How to get auto assigned id #410

Closed

sofisl mentioned this pull request Sep 15, 2022

migrate code from googleapis/nodejs-redis #3360

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 15, 2022

build: ignore proto files in test coverage (#175)

45e8630

sofisl mentioned this pull request Sep 16, 2022

migrate code from googleapis/nodejs-os-login #3366

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 16, 2022

update to .nycrc with --all enabled (#175)

21ef1d4

sofisl pushed a commit that referenced this pull request Sep 27, 2022

build: check broken links in generated docs (#175)

e1a40da

sofisl mentioned this pull request Sep 27, 2022

migrate code from googleapis/nodejs-video-intelligence #3374

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 5, 2022

update to .nycrc with --all enabled (#175)

8f4c8b5

sofisl mentioned this pull request Oct 5, 2022

migrate code from googleapis/nodejs-os-login #3388

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 5, 2022

update to .nycrc with --all enabled (#175)

fcbf1ed

sofisl mentioned this pull request Oct 8, 2022

migrate code from googleapis/nodejs-os-login #3389

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 8, 2022

update to .nycrc with --all enabled (#175)

df9caae

This was referenced Oct 11, 2022

migrate code from googleapis/nodejs-os-login #3391

Merged

migrate code from googleapis/nodejs-bigquery-data-transfer #3399

Merged

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-secret-manager #3553

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore(nodejs): update client ref docs link in metadata (#175)

184eb6c

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-billing #3556

Merged

migrate code from googleapis/nodejs-service-directory #3557

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore: release 3.3.0 (#175)

c972e35

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-media-translation #3558

Merged

migrate code from googleapis/nodejs-functions #3561

Merged

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-game-servers #3569

Merged

migrate code from googleapis/nodejs-workflows #3570

Merged

migrate code from googleapis/nodejs-video-transcoder #3571

Merged

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-channel #3577

Merged

migrate code from googleapis/nodejs-analytics-admin #3600

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore(main): release 3.2.0 (#175)

8aa33c2

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

release-please bot mentioned this pull request Nov 12, 2022

chore: release main #3529

Merged

sofisl mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-retail #3648

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 17, 2022

feat: use teeny-request to reduce module size (#175)

ce38b21

sofisl mentioned this pull request Nov 17, 2022

migrate code from googleapis/nodejs-compute #3666

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 24, 2023

doc: regenerate library README.md that got overwritten by samples REA…

c8290e3

…DME (#175)

sofisl pushed a commit that referenced this pull request Jan 25, 2023

doc: regenerate library README.md that got overwritten by samples REA…

df622ce

…DME (#175)

enterstudio mentioned this pull request Apr 19, 2023

[Snyk] Fix for 3 vulnerabilities enterstudio/google-cloud-node#155

Open

enterstudio mentioned this pull request Jun 26, 2023

[Snyk] Fix for 3 vulnerabilities enterstudio/google-cloud-node#156

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

datastore: expose ID, path, & namespace. fixes #171. #175

datastore: expose ID, path, & namespace. fixes #171. #175

stephenplusplus commented Sep 4, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Sep 5, 2014

stephenplusplus commented Sep 5, 2014

datastore: expose ID, path, & namespace. fixes #171. #175

datastore: expose ID, path, & namespace. fixes #171. #175

Conversation

stephenplusplus commented Sep 4, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Sep 5, 2014

stephenplusplus commented Sep 5, 2014