Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language: fix system tests #1739

Conversation

stephenplusplus
Copy link
Contributor

One of the Language system tests had a failure. Fixed that. But also, the terminal wasn't doing any reporting of the error-- it just exited the mocha process quietly. Wrapping the tests in a try/catch corrected this.

@stephenplusplus stephenplusplus added api: language Issues related to the Cloud Natural Language API API. testing labels Oct 21, 2016
@callmehiphop callmehiphop merged commit fe8e303 into googleapis:master Oct 21, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a26d43d on stephenplusplus:spp--language-system-tests-silent-failures into 88990ac on GoogleCloudPlatform:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: language Issues related to the Cloud Natural Language API API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants