New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core (grpc): correctly convert arrays & bools #1329

Merged

stephenplusplus merged 1 commit into googleapis:master from stephenplusplus:spp--1302-2

May 18, 2016

Contributor

stephenplusplus commented May 18, 2016

#1302 caught our object type being improperly converted. This addresses an additional report that we weren't accurate with two other types:

-booleanValue: true
+boolValue: true

-listValue = []
+listValue = { values: [] }


          core (grpc): correctly convert arrays & bools

a8f6b44

stephenplusplus added the core label

googlebot added the cla: yes label

stephenplusplus mentioned this pull request

Logger breaks on nested objects #1302

Closed

coveralls commented May 18, 2016 •

edited

Loading

Coverage remained the same at 100.0% when pulling a8f6b44 on stephenplusplus:spp--1302-2 into b877420 on GoogleCloudPlatform:master.

stephenplusplus merged commit 79b05af into googleapis:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels