Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ConfigStore to 1.0 #729

Closed
stephenplusplus opened this issue Jul 19, 2015 · 4 comments · Fixed by #730
Closed

Upgrade ConfigStore to 1.0 #729

stephenplusplus opened this issue Jul 19, 2015 · 4 comments · Fixed by #730
Assignees
@stephenplusplus

Comments

@stephenplusplus
Copy link
Contributor

It's just JSON now (formerly YAML), so we will save some processing power by upgrading.
@callmehiphop
Copy link
Contributor

This would be a breaking change wouldn't it?

@stephenplusplus
Copy link
Contributor Author

Kinda sorta. It's unique because it's a dependency for a feature the user doesn't realize exists, resumable uploads. If a resumable upload goes well, the information we cache is destroyed. So, ideally, the cache file is only non-empty for a brief amount of time.

But, it will be something to document for our next release. And since we're pre-1.0, each minor bump lets us go as yolo as we need to.

@callmehiphop callmehiphop mentioned this issue Jul 19, 2015
Merged
@callmehiphop
Copy link
Contributor

Is there a centralized location where we would document breaking changes? Or just add release notes to our tag..?

@stephenplusplus
Copy link
Contributor Author

We use the GitHub releases page as a changelog.

On Sunday, July 19, 2015, Dave Gramlich notifications@github.com wrote:

Is there a centralized location where we would document breaking changes?

—
Reply to this email directly or view it on GitHub
#729 (comment)
.

@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@yoshi-automation
docs: update comments on parameters and validation result (#729)
21c7422 
* docs: update comments on parameters and validation result.

PiperOrigin-RevId: 348673154

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Dec 22 12:11:37 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: 0795e3f854056696f330454023b9fa6d35053b79
Source-Link: googleapis/googleapis@0795e3f

* docs: update comments on parameters and validation result.

PiperOrigin-RevId: 348696929

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Dec 22 14:46:59 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: 8a6f4d9acb1620af2156b42b37b54eae257b7cad
Source-Link: googleapis/googleapis@8a6f4d9
sofisl added a commit that referenced this issue Nov 17, 2022
@sofisl
build: update library to use Node 12 (#729)
a419a0c 
* build: Update library to use Node 12
sofisl pushed a commit that referenced this issue Nov 17, 2022
@gcf-owl-bot @alexander-fenster @gcf-merge-on-green
build: use fully qualified request type name in tests (#786)
419d09b 
* feat: accept google-gax instance as a parameter

Please see the documentation of the client constructor for details.

PiperOrigin-RevId: 470332808

Source-Link: googleapis/googleapis@d4a2367

Source-Link: googleapis/googleapis-gen@e97a1ac
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk3YTFhYzIwNGVhZDRmZTczNDFmOTFlNzJkYjdjNmFjNjAxNjM0MSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: use _gaxModule when accessing gax for bundling

PiperOrigin-RevId: 470911839

Source-Link: googleapis/googleapis@3527566

Source-Link: googleapis/googleapis-gen@f16a1d2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjE2YTFkMjI0ZjAwYTYzMGVhNDNkNmE5YTFhMzFmNTY2ZjQ1Y2RlYSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat: Update Compute Engine API to revision 20220831 (#729)

Source-Link: googleapis/googleapis@63c3007

Source-Link: googleapis/googleapis-gen@b658223
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjY1ODIyMzFhZTdiN2Y1Y2QxOGY3ZDE0MmM2NTQyMTc3M2NjYTVkZSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: use gapic-generator-typescript v2.17.0

PiperOrigin-RevId: 474338479

Source-Link: googleapis/googleapis@d5d35e0

Source-Link: googleapis/googleapis-gen@efcd3f9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWZjZDNmOTM5NjJhMTAzZjY4ZjAwM2UyYTFlZWNkZTZmYTIxNmEyNyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* test: use fully qualified request type name in tests

PiperOrigin-RevId: 475685359

Source-Link: googleapis/googleapis@7a12973

Source-Link: googleapis/googleapis-gen@370c729
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzcwYzcyOWUyYmEwNjJhMTY3NDQ5YzI3ODgyYmE1ZjM3OWM1YzM0ZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Alexander Fenster <fenster@google.com>
Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>
@sofisl sofisl mentioned this issue Nov 17, 2022
Merged
4 tasks
@sofisl sofisl mentioned this issue Jan 10, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this issue Jan 10, 2023
@release-please @gcf-owl-bot
chore(main): release 4.1.0 (#729)
8de0d22 
* chore(main): release 4.1.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenplusplus stephenplusplus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bumped ConfigStore to 1.0
2 participants
@stephenplusplus @callmehiphop