Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datastore: groupBy filtering fails #25

Closed
rakyll opened this issue Jul 21, 2014 · 1 comment
Closed

datastore: groupBy filtering fails #25

rakyll opened this issue Jul 21, 2014 · 1 comment
Assignees
Labels
api: datastore Issues related to the Datastore API. 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@rakyll
Copy link
Contributor

rakyll commented Jul 21, 2014

/Users/jbd/gcloud-node/lib/datastore/entity.js:291
  query.groupBy = q.groupByVal.map(function(g) {
                               ^
TypeError: Object name has no method 'map'
    at Object.queryToQueryProto (/Users/jbd/gcloud-node/lib/datastore/entity.js:291:32)
    at Transaction.runQuery (/Users/jbd/gcloud-node/lib/datastore/index.js:263:19)
    at Dataset.runQuery (/Users/jbd/gcloud-node/lib/datastore/index.js:390:20)
    at Object.<anonymous> (/Users/jbd/gcloud-node/test.js:46:3)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
@rakyll
Copy link
Contributor Author

rakyll commented Jul 21, 2014

It's caused by passing a field name to groupBy, rather than a list of field names.

q.groupBy('name')

groupyBy now arrayizes the first argument. Fixed on bb7a70a.

@rakyll rakyll closed this as completed Jul 21, 2014
@jgeewax jgeewax added the api: datastore Issues related to the Datastore API. label Feb 2, 2015
@jgeewax jgeewax modified the milestones: M1: core, datastore & storage, Datastore Stable Feb 2, 2015
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
sofisl pushed a commit that referenced this issue Sep 16, 2022
* chore: the ultimate fix for repo-tools EPERM

* fix yaml references

* fix yaml references
sofisl pushed a commit that referenced this issue Oct 5, 2022
* chore: the ultimate fix for repo-tools EPERM

* fix yaml references

* fix yaml references
sofisl pushed a commit that referenced this issue Oct 8, 2022
* chore: the ultimate fix for repo-tools EPERM

* fix yaml references

* fix yaml references
sofisl pushed a commit that referenced this issue Oct 11, 2022
Release notes in the usual place on GitHub.
sofisl pushed a commit that referenced this issue Oct 12, 2022
* chore: lock files maintenance

* chore: lock files maintenance
sofisl pushed a commit that referenced this issue Dec 21, 2022
* chore(main): release 0.2.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this issue Jan 10, 2023
🤖 I have created a release *beep* *boop*
---


## [0.2.3](googleapis/nodejs-run@v0.2.2...v0.2.3) (2022-09-14)


### Bug Fixes

* Allow passing gax instance to client constructor ([#24](googleapis/nodejs-run#24)) ([91e2ac5](googleapis/nodejs-run@91e2ac5))
* Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-run/issues/1553)) ([#23](googleapis/nodejs-run#23)) ([acda49f](googleapis/nodejs-run@acda49f))
* Preserve default values in x-goog-request-params header ([#26](googleapis/nodejs-run#26)) ([debc1eb](googleapis/nodejs-run@debc1eb))
* use google-gax v3.3.0 ([acda49f](googleapis/nodejs-run@acda49f))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this issue Jan 24, 2023
sofisl pushed a commit that referenced this issue Jan 25, 2023
sofisl pushed a commit that referenced this issue Jan 26, 2023
* Add samples

* Fix linter errors

* Remove unnecessary samples and tests

* Fix minor linter error

* Remove unnecessary comments and other small updates

* Update project id

* Add samples

* Fix linter errors

* Remove unnecessary samples and tests

* Fix minor linter error

* Remove unnecessary comments and other small updates

* Update project id

* Remove terminal await calls

* Fix configuration issues

* Fix parsing error

* Update samples/package.json

* Update samples/predict-custom-trained-model.js

* Fix async file access for Node 10

* Ensmallify the example image

Co-authored-by: Eric Schmidt <erschmid@google.com>
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
sofisl pushed a commit that referenced this issue Feb 23, 2023
sofisl pushed a commit that referenced this issue Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants