-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Docs button looks already pressed on homepage #183
Comments
+2 I thought this as well. |
What would help? Flipping the hover color from dark to light (current) to light to dark? |
Easiest thing I can see is making the Docs button look like all the other |
@leomaia any ideas? :) |
I totally understand what you guys are saying. I designed this page to be prepared to house multiple docs pages from different programming languages. The main access to the page would be through a dropdown button next to the Google Cloud Platform logo which I would not remove it even with just one language. That would give a hint to users that more content will be added in the future. The red button would be a second and redundant point of access and that would be inserted in a carousel where you would be able to see multiple sets of "red button + external links", one for each language and instead of just simply "Docs" as a label for the button you would have "Node.js Docs", "Python Docs" and so on. Also, I wanted to make the button much more prominent than the other links. One simple fix would be to make the button's hover state more perceivable, maybe adding a darker border or a drop shadow. Another solution would be to provisionally change things a little bit in this area, dropping the red button and changing the title with a link to the "Docs" page. I attached some examples. |
Thanks for the background info. I think I prefer the text example, "Check out the Docs," or some variant of that phrasing, maybe even just "API Documentation". |
Cool! Even better. |
Thanks @leomaia! |
Sure! No problem. |
Fixed? |
- [ ] Regenerate this pull request now. Committer: @summer-ji-eng PiperOrigin-RevId: 434859890 Source-Link: googleapis/googleapis@bc2432d Source-Link: googleapis/googleapis-gen@930b673 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTMwYjY3MzEwM2U5MjUyM2Y4Y2ZlZDM4ZGVjZDdkM2FmYWU4ZWJlNyJ9
* test: use fully qualified request type name in tests PiperOrigin-RevId: 475685359 Source-Link: googleapis/googleapis@7a12973 Source-Link: googleapis/googleapis-gen@370c729 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzcwYzcyOWUyYmEwNjJhMTY3NDQ5YzI3ODgyYmE1ZjM3OWM1YzM0ZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* fix(docs): reference docs should link to section of googleapis.dev with API reference * fix(docs): make anchors work in jsdoc
* feat: support regapic LRO Use gapic-generator-typescript v2.15.1. PiperOrigin-RevId: 456946341 Source-Link: googleapis/googleapis@88fd18d Source-Link: googleapis/googleapis-gen@accfa37 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWNjZmEzNzFmNjY3NDM5MzEzMzM1YzY0MDQyYjA2M2MxYzUzMTAyZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* docs: fix docstring formatting Committer: parthea PiperOrigin-RevId: 449545643 Source-Link: googleapis/googleapis@1bed8a0 Source-Link: googleapis/googleapis-gen@d4ccc5f Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDRjY2M1ZmM2MTJjMjYwNTQ2YmNlY2VmMjg3MzU3NTY4OGEwMmQ4YiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: allow users to disable spell check in search requests feat: allow users to add labels in search requests docs: deprecate indexable/searchable on the product level custom attributes docs: keep the API doc up-to-date with recent changes PiperOrigin-RevId: 452193046 Source-Link: googleapis/googleapis@4e0282f Source-Link: googleapis/googleapis-gen@3fa3c84 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiM2ZhM2M4NGUzZGE4YzhlNjA0ZTEyOWMxNDEzNjdkZDA5MjY4NzhmMyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [2.0.0](googleapis/nodejs-retail@v1.8.1...v2.0.0) (2022-06-20) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#181) ### Features * allow users to disable spell check in search requests ([#183](googleapis/nodejs-retail#183)) ([05005ea](googleapis/nodejs-retail@05005ea)) ### Bug Fixes * **deps:** update dependency @google-cloud/bigquery to v6 ([#186](googleapis/nodejs-retail#186)) ([fc07923](googleapis/nodejs-retail@fc07923)) ### Build System * update library to use Node 12 ([#181](googleapis/nodejs-retail#181)) ([809853f](googleapis/nodejs-retail@809853f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ### [2.1.1](https://www.github.com/googleapis/nodejs-datacatalog/compare/v2.1.0...v2.1.1) (2020-07-09) ### Bug Fixes * typeo in nodejs .gitattribute ([#182](https://www.github.com/googleapis/nodejs-datacatalog/issues/182)) ([9e46bfc](https://www.github.com/googleapis/nodejs-datacatalog/commit/9e46bfce7847084d24d85218d5a294ff7c46e2ff)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Docs button on the homepage is highlighted in a way that it looks already pressed and I'm reading "Docs". I looked around for a while to find a link to JSDocs, knowing that they are somewhere. A user will likely to close the page assuming there is nothing besides the homepage.
The text was updated successfully, but these errors were encountered: