Minor clarification of GCS data validation docs; change default hash algo? #1749
Labels
api: storage
Issues related to the Cloud Storage API.
type: question
Request for information or clarification. Not an issue.
The docs for createReadStream and createWriteStream say
It appears that actually both are calculated, and both are verified if present (although the md5 check overrules the crc32c check), so I think it would be more accurate to say
But, using a cryptographic hash seems like an overkill default. What do you think of changing it to by default calculating CRC32c only, and not calculating MD5 unless the validation method is "MD5"?
(Also, if you specify "md5" then it does not appear to fallback to CRC32c if there was no MD5 returned -- ideally it would fallback instead of doing zero validation, I think?)
The text was updated successfully, but these errors were encountered: