chore: stop pre-building binaries in e2e tests (#430)

Author: nolanmar511

handwritten/cloud-profiler/testing/integration_test.go

@@ -39,7 +39,6 @@ var (
 	commit              = flag.String("commit", "", "git commit to test")
 	pr                  = flag.Int("pr", 0, "git pull request to test")
 	runOnlyV8CanaryTest = flag.Bool("run_only_v8_canary_test", false, "if true test will be run only with the v8-canary build, otherwise, no tests will be run with v8 canary")
-	binaryHost          = flag.String("binary_host", "", "host from which to download precompiled binaries; if no value is specified, binaries will be built from source.")
 
 	runID             = strings.Replace(time.Now().Format("2006-01-02-15-04-05.000000-0700"), ".", "-", -1)
 	benchFinishString = "busybench finished profiling"
@@ -74,7 +73,7 @@ set -eo pipefail
 set -x
 # Install git
 retry apt-get update >/dev/null
-retry apt-get -y -q install git {{if not .BinaryHost}}build-essential{{end}} >/dev/null
+retry apt-get -y -q install git build-essential >/dev/null
 
 # Install desired version of Node.js
 retry curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.8/install.sh | bash >/dev/null
@@ -95,7 +94,7 @@ retry git fetch origin {{if .PR}}pull/{{.PR}}/head{{else}}{{.Branch}}{{end}}:pul
 git checkout pull_branch
 git reset --hard {{.Commit}}
 
-retry npm install --nodedir="$NODEDIR" {{if.BinaryHost}}--fallback-to-build=false --google_cloud_profiler_binary_host_mirror={{.BinaryHost}}{{end}} >/dev/null
+retry npm install --nodedir="$NODEDIR" >/dev/null
 
 # TODO: remove this workaround.
 # For v8-canary tests, we need to use the version of NAN on github, which 
@@ -114,11 +113,7 @@ cp -r "testing/busybench" "$TESTDIR"
 cd "$TESTDIR/busybench"
 
 retry npm install node-pre-gyp
-{{if .BinaryHost}}
-retry npm install --nodedir="$NODEDIR" --fallback-to-build=false --google_cloud_profiler_binary_host_mirror={{.BinaryHost}} "$PROFILER" typescript gts >/dev/null
-{{else}}
 retry npm install --nodedir="$NODEDIR" --build-from-source=google_cloud_profiler "$PROFILER" typescript gts >/dev/null
-{{end}}
 
 npm run compile
 
@@ -159,7 +154,6 @@ func (tc *nodeGCETestCase) initializeStartUpScript(template *template.Template)
 			Commit       string
 			FinishString string
 			ErrorString  string
-			BinaryHost   string
 		}{
 			Service:      tc.name,
 			NodeVersion:  tc.nodeVersion,
@@ -170,7 +164,6 @@ func (tc *nodeGCETestCase) initializeStartUpScript(template *template.Template)
 			Commit:       *commit,
 			FinishString: benchFinishString,
 			ErrorString:  errorString,
-			BinaryHost:   *binaryHost,
 		})
 	if err != nil {
 		return fmt.Errorf("failed to render startup script for %s: %v", tc.name, err)

handwritten/cloud-profiler/testing/integration_test.sh

@@ -34,8 +34,8 @@ cp -R "testing" "$GOPATH/src/proftest"
 cd "$GOPATH/src/proftest"
 retry go get -t -d -tags=integration .
 if [ "$KOKORO_GITHUB_PULL_REQUEST_NUMBER" = "" ]; then
-  go test -timeout=30m -tags=integration -run TestAgentIntegration -commit="$COMMIT" -branch="$BRANCH" -repo="$REPO" -run_only_v8_canary_test="$RUN_ONLY_V8_CANARY_TEST" -binary_host="$BINARY_HOST"
+  go test -timeout=30m -tags=integration -run TestAgentIntegration -commit="$COMMIT" -branch="$BRANCH" -repo="$REPO" -run_only_v8_canary_test="$RUN_ONLY_V8_CANARY_TEST"
 else
-  go test -timeout=30m -tags=integration -run TestAgentIntegration -commit="$COMMIT" -pr="$KOKORO_GITHUB_PULL_REQUEST_NUMBER" -run_only_v8_canary_test="$RUN_ONLY_V8_CANARY_TEST" -binary_host="$BINARY_HOST"
+  go test -timeout=30m -tags=integration -run TestAgentIntegration -commit="$COMMIT" -pr="$KOKORO_GITHUB_PULL_REQUEST_NUMBER" -run_only_v8_canary_test="$RUN_ONLY_V8_CANARY_TEST"
 fi
 

handwritten/cloud-profiler/tools/build.sh

@@ -13,4 +13,4 @@
 # limitations under the License.
 
 # Location of the build script in this repository.
-build_file: "cloud-profiler-nodejs/tools/linux_build_and_test.sh"
+build_file: "cloud-profiler-nodejs/testing/integration_test.sh"

handwritten/cloud-profiler/tools/kokoro/continuous/continuous.cfg

@@ -13,4 +13,4 @@
 # limitations under the License.
 
 # Location of the build script in this repository.
-build_file: "cloud-profiler-nodejs/tools/linux_build_and_test.sh"
+build_file: "cloud-profiler-nodejs/testing/integration_test.sh"

handwritten/cloud-profiler/tools/kokoro/presubmit/presubmit.cfg

@@ -13,4 +13,4 @@
 # limitations under the License.
 
 # Location of the build script in this repository.
-build_file: "cloud-profiler-nodejs/tools/linux_build_and_test.sh"
+build_file: "cloud-profiler-nodejs/testing/integration_test.sh"