Bigtable: limit mutation sizes in the client to avoid overloading the server#3695
Merged
pongad merged 2 commits intogoogleapis:masterfrom Sep 18, 2018
Merged
Bigtable: limit mutation sizes in the client to avoid overloading the server#3695pongad merged 2 commits intogoogleapis:masterfrom
pongad merged 2 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
Author
|
@kevinsi4508, can you take a look when you have a moment? |
sduskis
reviewed
Sep 18, 2018
| "Byte size of mutations is too large"); | ||
|
|
||
| numMutations++; | ||
| byteSize += mutation.getSerializedSize(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
kevinsi4508
approved these changes
Sep 18, 2018
| @InternalApi("Visible for testing") | ||
| static final int MAX_MUTATIONS = 100_000; | ||
| @InternalApi("Visible for testing") | ||
| static final int MAX_MUTATION_SIZE = 200 * 1024 * 1024; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Author
|
@pongad this is ready for you when you get a chance |
pongad
approved these changes
Sep 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.