Skip to content

pubsub: make Publisher/Subscriber accept plain strings#3018

Merged
pongad merged 2 commits intogoogleapis:masterfrom
pongad:pubsub-resource
Mar 12, 2018
Merged

pubsub: make Publisher/Subscriber accept plain strings#3018
pongad merged 2 commits intogoogleapis:masterfrom
pongad:pubsub-resource

Conversation

@pongad
Copy link
Contributor

@pongad pongad commented Mar 9, 2018

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 9, 2018

/** Subscription which the subscriber is subscribed to. */
public ProjectSubscriptionName getSubscriptionName() {
return ProjectSubscriptionName.parse(subscriptionName);

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

return TopicNames.parse(topicName);
}

/** Topic which the publisher publishes to. */

This comment was marked as spam.

This comment was marked as spam.


/** Subscription which the subscriber is subscribed to. */
public ProjectSubscriptionName getSubscriptionName() {
return ProjectSubscriptionName.parse(subscriptionName);

This comment was marked as spam.

Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh also LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants