logging: don't hard code config string#1728
Merged
pongad merged 2 commits intogoogleapis:masterfrom Mar 12, 2017
pongad:logging-config
Merged
logging: don't hard code config string#1728pongad merged 2 commits intogoogleapis:masterfrom pongad:logging-config
pongad merged 2 commits intogoogleapis:masterfrom
pongad:logging-config
Conversation
This PR turns the hard coded config string into a map and a rendering function. This doesn't do anything straightaway, but will simplify #1721 .
googlebot
added
the
cla: yes
|
Changes Unknown when pulling 56d06ad on pongad:logging-config into ** on GoogleCloudPlatform:master**. |
|
Changes Unknown when pulling 56d06ad on pongad:logging-config into ** on GoogleCloudPlatform:master**. |
Contributor
|
LGTM |
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Jan 22, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Feb 24, 2026
* fix: Do not add padding in Client-Side CAB tokens. Change-Id: I1dc0dfeb7e29e902ad3442cae28d10383816f58b * Add unit test assertions to verify the generated token has no padding. Change-Id: I7b948a13a075d7afeac19f96b9372f23b60d4eda * Add comment to explain why padding is removed. Change-Id: I0882e0c5d99310b179ace493b937669520626263 * Run mvn format. Change-Id: I8e3c59c42fceeaf593fa08e85b40754d57e71a45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR turns the hard coded config string into
a map and a rendering function.
This doesn't do anything straightaway,
but will simplify #1721 .