logging: clean up test#1720
Merged
pongad merged 3 commits intogoogleapis:masterfrom Mar 9, 2017
pongad:logging-clean-test
Merged
logging: clean up test#1720pongad merged 3 commits intogoogleapis:masterfrom pongad:logging-clean-test
pongad merged 3 commits intogoogleapis:masterfrom
pongad:logging-clean-test
Conversation
no change in behavior
|
Changes Unknown when pulling eea697f on pongad:logging-clean-test into ** on GoogleCloudPlatform:master**. |
| .addLabel("levelValue", String.valueOf(LoggingLevel.EMERGENCY.intValue())) | ||
| .setTimestamp(123456789L) | ||
| .build(); | ||
| private static final WriteOption[] DEFAULT_OPTION = |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@garrettjonesgoogle PTAL |
Member
|
LGTM after >=1 tests pass |
Contributor
Author
|
Everything passed except Mac which hasn't started. Merging. |
|
Changes Unknown when pulling c8c3597 on pongad:logging-clean-test into ** on GoogleCloudPlatform:master**. |
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
…#1720) * chore: Update generation configuration at Sat Oct 26 02:21:38 UTC 2024 * chore: Update generation configuration at Sun Oct 27 02:26:17 UTC 2024 * chore: Update generation configuration at Tue Oct 29 02:24:43 UTC 2024 * chore: Update generation configuration at Wed Oct 30 02:24:18 UTC 2024 * chore: Update generation configuration at Thu Oct 31 02:24:57 UTC 2024 * chore: Update generation configuration at Fri Nov 1 02:27:14 UTC 2024 * chore: Update generation configuration at Sat Nov 2 02:22:19 UTC 2024 * chore: generate libraries at Sat Nov 2 02:23:00 UTC 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no change in behavior