Add async/sync setting to logging handler by michaelbausor · Pull Request #1716 · googleapis/google-cloud-java

michaelbausor · 2017-03-08T19:41:44Z

Two questions:

I don't like WriteLogMethod much as a setting name. WriteSyncType? Others?
I am using a switch in write(). Any preference to instead set a callable at construction time? Or something else?

michaelbausor · 2017-03-08T19:42:01Z

google-cloud-logging/src/test/java/com/google/cloud/logging/BaseSystemTest.java

            "instance_id", "instance",
            "zone", "us-central1-a"));
-    LoggingHandler handler = new AsyncLoggingHandler(logName, options, resource);
+    LoggingHandler handler = new LoggingHandler(logName, options, resource);


google-cloud-logging/src/test/java/com/google/cloud/logging/BaseSystemTest.java

+          new ByteArrayInputStream(
+              "com.google.cloud.logging.LoggingHandler.writeLogMethod=SYNC".getBytes()));
+    } catch (Exception e) {
+      throw new RuntimeException(e);


google-cloud-logging/src/main/java/com/google/cloud/logging/WriteLogMethod.java

+
+package com.google.cloud.logging;
+
+public enum WriteLogMethod {


michaelbausor · 2017-03-08T20:25:00Z

PTAL. Also, should we have tests to make sure that settings in the properties file are read correctly?

garrettjonesgoogle · 2017-03-08T20:27:07Z

Yes, I think we should have a test for the properties file settings.

google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingHandler.java

      return Collections.emptyList();
    }
+
+    Synchronicity getSynchronicityProperty(String name, Synchronicity defaultValue) {


google-cloud-logging/src/main/java/com/google/cloud/logging/Synchronicity.java

+
+package com.google.cloud.logging;
+
+public enum Synchronicity {


coveralls · 2017-03-08T23:00:57Z

Coverage increased (+0.007%) to 81.492% when pulling e7e4fc2 on michaelbausor:async-setting into 33d824d on GoogleCloudPlatform:master.

coveralls · 2017-03-08T23:43:25Z

Coverage increased (+0.01%) to 81.498% when pulling 7ba4868 on michaelbausor:async-setting into 33d824d on GoogleCloudPlatform:master.

google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingHandler.java

 import java.util.logging.LogRecord;
 import java.util.logging.Logger;
 import java.util.logging.SimpleFormatter;
+import com.google.cloud.logging.Logging.WriteOption;


google-cloud-logging/src/main/java/com/google/cloud/logging/Synchronicity.java

+
+package com.google.cloud.logging;
+
+public enum Synchronicity {


michaelbausor · 2017-03-09T17:02:29Z

PTAL

garrettjonesgoogle · 2017-03-09T17:13:59Z

LGTM

* Add async/sync setting to logging handler

…e to v2.25.3 (#1716) Co-authored-by: Cindy Peng <148148319+cindy-peng@users.noreply.github.com>

michaelbausor added 2 commits March 8, 2017 11:34

Add async/sync setting to logging handler

af16e2a

Adjust comments

e7e4fc2

michaelbausor requested review from garrettjonesgoogle and pongad March 8, 2017 19:41

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 8, 2017

garrettjonesgoogle reviewed Mar 8, 2017

View reviewed changes

michaelbausor added 2 commits March 8, 2017 12:16

Address PR feedback

a1cf94a

Update format

7ba4868

garrettjonesgoogle reviewed Mar 8, 2017

View reviewed changes

pongad suggested changes Mar 8, 2017

View reviewed changes

michaelbausor added 3 commits March 8, 2017 16:40

Add logging properties test

57aa841

Address PR feedback, apply formatting

48e73d7

Address PR comments

acad245

michaelbausor merged commit b698b13 into googleapis:master Mar 9, 2017

michaelbausor deleted the async-setting branch March 9, 2017 17:17

michaelbausor changed the title ~~WIP: Add async/sync setting to logging handler~~ Add async/sync setting to logging handler Mar 9, 2017

michaelbausor mentioned this pull request Mar 9, 2017

Deprecate AsyncLoggingHandler? #1532

Closed

michaelbausor added a commit that referenced this pull request Mar 9, 2017

Add async/sync setting to logging handler (#1716)

ff24b05

* Add async/sync setting to logging handler

michaelbausor mentioned this pull request Mar 9, 2017

logging: reduce message size #1721

Merged

4 tasks

chingor13 pushed a commit that referenced this pull request Jan 22, 2026

chore(deps): update dependency com.google.cloud:google-cloud-datastor…

0e1a2d6

…e to v2.25.3 (#1716) Co-authored-by: Cindy Peng <148148319+cindy-peng@users.noreply.github.com>


		package com.google.cloud.logging;

		public enum WriteLogMethod {


		package com.google.cloud.logging;

		public enum Synchronicity {

Conversation

michaelbausor commented Mar 8, 2017

Uh oh!

michaelbausor commented Mar 8, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

michaelbausor commented Mar 8, 2017

Uh oh!

garrettjonesgoogle commented Mar 8, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Mar 8, 2017

Uh oh!

coveralls commented Mar 8, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

michaelbausor commented Mar 9, 2017

Uh oh!

garrettjonesgoogle commented Mar 9, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants