Skip to content

move hand written pubsub code to deprecated namespace#1598

Merged
pongad merged 2 commits intogoogleapis:masterfrom
pongad:deprecate
Feb 9, 2017
Merged

move hand written pubsub code to deprecated namespace#1598
pongad merged 2 commits intogoogleapis:masterfrom
pongad:deprecate

Conversation

@pongad
Copy link
Contributor

@pongad pongad commented Feb 8, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2017
@garrettjonesgoogle
Copy link
Member

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.451% when pulling eb805f7 on pongad:deprecate into c230c0f on GoogleCloudPlatform:master.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6ba75c1 on pongad:deprecate into ** on GoogleCloudPlatform:master**.

@pongad pongad merged commit fa0720c into googleapis:master Feb 9, 2017
@pongad pongad deleted the deprecate branch February 9, 2017 05:04
chingor13 pushed a commit that referenced this pull request Feb 24, 2026
…ality (#1629)

* feat: Implement ClientSideCredentialAccessBoundaryFactory (#1562)

* feat: Implement ClientSideCredentialAccessBoundaryFactory.refreshCredentials()

Set up the ClientSideCredentialAccessBoundaryFactory class and module.
Implement the function to fetch and refresh intermediary tokens from STS.

* feat: Add the generated ClientSideAccessBoundaryProto class for Client-Side CAB feature. (#1571)

Change-Id: Ic7ef3cbd80b2ad778d61b9ccabf780561d3cc709

* feat: Implement refreshCredentialsIfRequired for intermediate token r… (#1583)

* feat: Implement refreshCredentialsIfRequired for intermediate token refresh

Implement `refreshCredentialsIfRequired`, called by `generateToken()`, to handle token refresh. It uses `refreshMargin` and `minimumTokenLifetime` to decide on synchronous or asynchronous refresh

* Add unit tests for the builder and refreshCredentials()

* Improve concurrency handling during credential refresh.

Introduced a refresh task to manage concurrent refresh requests, preventing redundant attempts and potential race conditions. This aligns the refresh mechanism with the pattern used in OAuth2Credentials and ensures more robust credential management.

* Update existing unit tests for compatibility and readability.

* Add unit tests for refreshCredentialsIfRequired.

* Fix a merge issue.

* Temporary add sonatype-snapshots repository and cel version to fix the build error.

* Remove duplicated code.

* Fix lint issue.

* Fix: Propagate credential refresh exceptions in blocking refresh.

* Change cel version

* Change cel version

* Add jsr305 dependency

* Fix Javadoc error

* Minor code readability enhancements.

* Revert "Fix Javadoc error"

This reverts commit 2157fdb767d70a4784417bd24c7074e088869d39.

* Address comments (add javadoc and use assertThrows in tests)

* Run format script

* feat: Implement Client-Side CAB token generation.  (#1598)

* feat: Implement Client-Side CAB token generation.

Change-Id: I2c217656584cf5805297f02340cbbabca471f609

* Use IllegalStateException(String, Throwable) to capture upstream exception during Tink initialization

Change-Id: I12af5b84eae4dcec5865adfdad1f9396d54c0200

* Rethrow exceptions from tink and CEL

Change-Id: If8c94c786ee39201029d9c27856fd2eafb61e51c

* Add tests for invalid keys from upstream, and rename test cases.

Change-Id: Ib41cb81c779534fc6efd74d66bf4728efd743906

* Add additional throws comment for generatToken method.

Change-Id: I9cfc589ade8a91040fc9c447740493fd49e392af

* Refactor tests for better readability.

Change-Id: Icfd0bc24c1694f220bcbffc6cde41462c59119c4

* Catch and rethrow the exception of session key not being base64 encoded.

Change-Id: I5fa0c25fe020e9612735e4ac5df2b85a2a5aab11

* Format the code using mvn com.coveo:fmt-maven-plugin:format.

Change-Id: I46572488dcd28de450a6b1b2f732bee5baa86910

* Fix a typo in the javadoc comment.

Change-Id: Icef9ef5f7c3567224ec507303543b78e61f43ec1

* chore: Update version tag in cab-token-generator pom.xml

This commit updates the version tag in the pom.xml file.

* feat: Add integration test for the client side cab

* Remove volatile keyword and use refreshLock when reading intermediateCredentials.

* Define new default values for refreshMargin and minimumTokenLifetime.

* Update version in pom.xml

* Run formatter to resolve lint errors

* add missing dependency

* Swap the assertEquals parameters so the expected value is first.

* Docs: Added javadocs

Improvements: Cleaned up code, resolved readability enhancements

---------

Co-authored-by: Jiahua Huang <jh@jiahuah.com>
Co-authored-by: aeitzman <12433791+aeitzman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants