-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use white flat svg instead of old java duke icon #147
Conversation
LGTM |
Use white flat svg instead of old java duke icon
Question on process: this logo change on gcloud-java's landing page only go into effect next time somebody on gcloud-java runs maven's site-deploy (since Travis times out building the website at the moment, we have to do it manually. This is going to change soon). Since regenerating and deploying the entire website+docs takes ~2 hrs and seems a bit excessive for just a logo update, do you think I should push those changes directly to gh-pages for the time being? And if so, should that go via PR, or just directly? cc/ @dhermes |
😮 |
I am fine with a PR for changing the icon though I do wonder if it is desired to copy all resources for every site version... Alternative would be to have some of the resources (such as icons) to be checked into gh-pages (e.g. /icons/) and change the relevant links/references to use full path (e.g. /icons/icon-lang-java-duke-white.svg). Also, slightly related, I think we should cleanup gh-pages and remove the old content and instead add a redirect to latest directly at the root of gh-pages so http://googlecloudplatform.github.io/gcloud-java/ will take us to the right place). |
Pushing all new stuff shouldn't be a 2 hour operation.... Can we make work
towards fixing that issue?
We're talking about a minute max for Python, Node, Ruby, etc, and they
cover far more APIs.... I'm going to guess if we make this faster, the
problem goes away. (This is eerily reminding me of our old 200mb repository
problem...)
|
Alright, I'll work on that now. |
@aozarov, just to make sure we're on the same page, I'm planning to:
Let me know if that all sounds right. Since these are a lot of changes, I'll split them into two PRs |
That sounds right. I assume the 2 hours (for me it does not take that long) includes the push time? |
Yeah, the 2 hours was a push time for my last deployment. When I run site and then stage, it takes my machine ~4 minutes. Hopefully travis will work at least that fast so we won't hit the timeouts. |
Source-Link: googleapis/synthtool@7336562 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:d4b80feffe1579818cdc39466152e9de95789a193408506cd4a1ffbe8804dc00
🤖 I have created a release *beep* *boop* --- ## [1.2.2](googleapis/java-iam-admin@v1.2.1...v1.2.2) (2022-07-13) ### Bug Fixes * enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-iam-admin/issues/1485)) ([#147](googleapis/java-iam-admin#147)) ([3f428db](googleapis/java-iam-admin@3f428db)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
…onfig to v1.5.3 (#147) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.5.1` -> `1.5.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.3/compatibility-slim/1.5.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.3/confidence-slim/1.5.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.5.3`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#​153-httpsgithubcomgoogleapisjava-shared-configcomparev152v153-2022-07-27) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.5.2...v1.5.3) ##### Dependencies - update dependency org.junit.vintage:junit-vintage-engine to v5.9.0 ([#​497](https://togithub.com/googleapis/java-shared-config/issues/497)) ([1fc6ab4](https://togithub.com/googleapis/java-shared-config/commit/1fc6ab445624cd4f9c8b161d109f346a9e5ed09a)) - Update doclet to latest version 1.6.0 ([38fb7c3](https://togithub.com/googleapis/java-shared-config/commit/38fb7c3957fb6c9b2da10f9e463cc93a8b80a3a4)) ### [`v1.5.2`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#​152-httpsgithubcomgoogleapisjava-shared-configcomparev151v152-2022-07-25) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.5.1...v1.5.2) ##### Dependencies - update dependency com.puppycrawl.tools:checkstyle to v10 ([#​435](https://togithub.com/googleapis/java-shared-config/issues/435)) ([bfc8ce1](https://togithub.com/googleapis/java-shared-config/commit/bfc8ce1deca6292147d002d3afe22a09840aa5d6)) - update dependency org.graalvm.buildtools:junit-platform-native to v0.9.13 ([#​488](https://togithub.com/googleapis/java-shared-config/issues/488)) ([39b91ee](https://togithub.com/googleapis/java-shared-config/commit/39b91ee1283f0a5fbbe63e8bfd1ec97ab4ab377e)) - update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.13 ([#​489](https://togithub.com/googleapis/java-shared-config/issues/489)) ([cc3bcfa](https://togithub.com/googleapis/java-shared-config/commit/cc3bcfa2d6717441a8d5b5048fa78c2cf7aabf2b)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-deploy). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzUuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEzNS4xIn0=-->
🤖 I have created a release *beep* *boop* --- ## [0.5.0](googleapis/java-bigquerymigration@v0.4.1...v0.5.0) (2022-08-02) ### Features * Add Presto dialect to bigquerymigration v2 client library ([#143](googleapis/java-bigquerymigration#143)) ([cb547fb](googleapis/java-bigquerymigration@cb547fb)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#151](googleapis/java-bigquerymigration#151)) ([a3df42c](googleapis/java-bigquerymigration@a3df42c)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.1 ([#152](googleapis/java-bigquerymigration#152)) ([4550035](googleapis/java-bigquerymigration@4550035)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [1.3.3](googleapis/java-vmmigration@v1.3.2...v1.3.3) (2022-09-29) ### Dependencies * Update dependency cachetools to v5 ([#162](googleapis/java-vmmigration#162)) ([673c232](googleapis/java-vmmigration@673c232)) * Update dependency certifi to v2022.9.24 ([#142](googleapis/java-vmmigration#142)) ([40be099](googleapis/java-vmmigration@40be099)) * Update dependency charset-normalizer to v2.1.1 ([#146](googleapis/java-vmmigration#146)) ([c82b8bd](googleapis/java-vmmigration@c82b8bd)) * Update dependency click to v8.1.3 ([#147](googleapis/java-vmmigration#147)) ([99e10f7](googleapis/java-vmmigration@99e10f7)) * Update dependency gcp-releasetool to v1.8.8 ([#143](googleapis/java-vmmigration#143)) ([778f845](googleapis/java-vmmigration@778f845)) * Update dependency google-api-core to v2.10.1 ([#148](googleapis/java-vmmigration#148)) ([7b74afa](googleapis/java-vmmigration@7b74afa)) * Update dependency google-auth to v2.12.0 ([#149](googleapis/java-vmmigration#149)) ([6585870](googleapis/java-vmmigration@6585870)) * Update dependency google-cloud-core to v2.3.2 ([#144](googleapis/java-vmmigration#144)) ([cb815f8](googleapis/java-vmmigration@cb815f8)) * Update dependency google-cloud-storage to v2.5.0 ([#150](googleapis/java-vmmigration#150)) ([89e854a](googleapis/java-vmmigration@89e854a)) * Update dependency google-crc32c to v1.5.0 ([#151](googleapis/java-vmmigration#151)) ([dc88700](googleapis/java-vmmigration@dc88700)) * Update dependency googleapis-common-protos to v1.56.4 ([#145](googleapis/java-vmmigration#145)) ([5c8312d](googleapis/java-vmmigration@5c8312d)) * Update dependency importlib-metadata to v4.12.0 ([#152](googleapis/java-vmmigration#152)) ([c4ffddc](googleapis/java-vmmigration@c4ffddc)) * Update dependency jeepney to v0.8.0 ([#153](googleapis/java-vmmigration#153)) ([d84c437](googleapis/java-vmmigration@d84c437)) * Update dependency jinja2 to v3.1.2 ([#154](googleapis/java-vmmigration#154)) ([6682d82](googleapis/java-vmmigration@6682d82)) * Update dependency keyring to v23.9.3 ([#155](googleapis/java-vmmigration#155)) ([3d1a2d6](googleapis/java-vmmigration@3d1a2d6)) * Update dependency markupsafe to v2.1.1 ([#156](googleapis/java-vmmigration#156)) ([5666a1e](googleapis/java-vmmigration@5666a1e)) * Update dependency protobuf to v3.20.2 ([#157](googleapis/java-vmmigration#157)) ([e422694](googleapis/java-vmmigration@e422694)) * Update dependency protobuf to v4 ([#163](googleapis/java-vmmigration#163)) ([39884b8](googleapis/java-vmmigration@39884b8)) * Update dependency pyjwt to v2.5.0 ([#158](googleapis/java-vmmigration#158)) ([af206d0](googleapis/java-vmmigration@af206d0)) * Update dependency requests to v2.28.1 ([#159](googleapis/java-vmmigration#159)) ([83eb4d1](googleapis/java-vmmigration@83eb4d1)) * Update dependency typing-extensions to v4.3.0 ([#160](googleapis/java-vmmigration#160)) ([9d2cf45](googleapis/java-vmmigration@9d2cf45)) * Update dependency zipp to v3.8.1 ([#161](googleapis/java-vmmigration#161)) ([1ad1a9c](googleapis/java-vmmigration@1ad1a9c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
…-publishing to v0.3.5 (#147) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-eventarc-publishing](https://togithub.com/googleapis/java-eventarc-publishing) | `0.3.4` -> `0.3.5` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-eventarc-publishing/0.3.5/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-eventarc-publishing/0.3.5/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-eventarc-publishing/0.3.5/compatibility-slim/0.3.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-eventarc-publishing/0.3.5/confidence-slim/0.3.4)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-eventarc-publishing). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMiIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4yIn0=-->
Here's a screenshot: