Skip to content

Method names in StructuredQuery.PropertyFilter are non-obvious #99

Closed
@eamonnmcmanus

Description

StructuredQuery.PropertyFilter includes these static methods:

  • eq
  • gt
  • gte
  • le
  • lte

I think it's very non-obvious that le in particular means less-than rather than less-than-or-equal. I propose spelling out these names:

  • equals(String property, T value)
  • greaterThan
  • greaterThanOrEqual
  • lessThan
  • lessThanOrEqual

Metadata

Assignees

Labels

🚨This issue needs some love.triage meI really want to be triaged.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions