Minor checkstyle and codacy fixes to gcloud-java-nio

Author: mziccard

gcloud-java-contrib/gcloud-java-nio/src/main/java/com/google/cloud/storage/contrib/nio/CloudStorageConfiguration.java

@@ -28,6 +28,8 @@
 @AutoValue
 public abstract class CloudStorageConfiguration {
 
+  public static final CloudStorageConfiguration DEFAULT = builder().build();
+
   /**
    * Returns path of current working directory. This defaults to the root directory.
    */
@@ -147,8 +149,6 @@ public CloudStorageConfiguration build() {
     Builder() {}
   }
 
-  public static final CloudStorageConfiguration DEFAULT = builder().build();
-
   static CloudStorageConfiguration fromMap(Map<String, ?> env) {
     Builder builder = builder();
     for (Map.Entry<String, ?> entry : env.entrySet()) {

gcloud-java-contrib/gcloud-java-nio/src/main/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystem.java

@@ -37,8 +37,6 @@
 
 import javax.annotation.CheckReturnValue;
 import javax.annotation.Nullable;
-import javax.annotation.concurrent.Immutable;
-import javax.annotation.CheckReturnValue;
 import javax.annotation.concurrent.ThreadSafe;
 
 /**

gcloud-java-contrib/gcloud-java-nio/src/main/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystemProvider.java

@@ -308,10 +308,10 @@ private SeekableByteChannel newWriteChannel(Path path, Set<? extends OpenOption>
 
     try {
       return new CloudStorageWriteChannel(
-          storage.writer(
-              infoBuilder.build(), writeOptions.toArray(new Storage.BlobWriteOption[0])));
+          storage.writer(infoBuilder.build(),
+              writeOptions.toArray(new Storage.BlobWriteOption[writeOptions.size()])));
     } catch (StorageException oops) {
-      throw asIOException(oops);
+      throw asIoException(oops);
     }
   }
 
@@ -471,7 +471,7 @@ public void copy(Path source, Path target, CopyOption... options) throws IOExcep
       CopyWriter copyWriter = storage.copy(copyReqBuilder.build());
       copyWriter.result();
     } catch (StorageException oops) {
-      throw asIOException(oops);
+      throw asIoException(oops);
     }
   }
 
@@ -623,7 +623,7 @@ public String toString() {
     return MoreObjects.toStringHelper(this).add("storage", storage).toString();
   }
 
-  private IOException asIOException(StorageException oops) {
+  private IOException asIoException(StorageException oops) {
     // RPC API can only throw StorageException, but CloudStorageFileSystemProvider
     // can only throw IOException. Square peg, round hole.
     // TODO(#810): Research if other codes should be translated similarly.

gcloud-java-contrib/gcloud-java-nio/src/test/java/com/google/cloud/storage/contrib/nio/CloudStorageWriteChannelTest.java

@@ -49,7 +49,7 @@ public class CloudStorageWriteChannelTest {
   @Rule public final ExpectedException thrown = ExpectedException.none();
 
   private final WriteChannel gcsChannel = mock(WriteChannel.class);
-  private CloudStorageWriteChannel chan = new CloudStorageWriteChannel(gcsChannel);
+  private final CloudStorageWriteChannel chan = new CloudStorageWriteChannel(gcsChannel);
 
   @Before
   public void before() {