Skip to content

Commit d23d166

Browse files
committed
pr comment
1 parent c0f945f commit d23d166

File tree

1 file changed

+5
-3
lines changed
  • google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1

1 file changed

+5
-3
lines changed

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import com.google.api.gax.grpc.InstantiatingExecutorProvider;
2525
import com.google.auth.oauth2.GoogleCredentials;
2626
import com.google.common.annotations.VisibleForTesting;
27-
import com.google.common.base.Optional;
2827
import com.google.common.base.Preconditions;
2928
import com.google.common.collect.ImmutableList;
3029
import com.google.common.util.concurrent.FutureCallback;
@@ -586,9 +585,12 @@ private Builder(TopicName topic) {
586585
}
587586

588587
/**
589-
* ChannelProvider to use to create Channels.
588+
* {@code ChannelProvider} to use to create Channels, which must point at Cloud Pub/Sub
589+
* endpoint.
590590
*
591-
* <p>Must point at Cloud Pub/Sub endpoint.
591+
* <p>For performance, this client benefits from having multiple channels open at once. Users
592+
* are encouraged to provide instances of {@code ChannelProvider} that creates new channels
593+
* instead of returning pre-initialized ones.
592594
*/
593595
public Builder setChannelProvider(ChannelProvider channelProvider) {
594596
this.channelProvider = Preconditions.checkNotNull(channelProvider);

0 commit comments

Comments
 (0)