Skip to content

Commit b52e8cc

Browse files
committed
chore(java-cloud-bom): fix lint failure by adding missing modules to reactor and skipping deploy/checkstyle
1 parent 63512cf commit b52e8cc

9 files changed

Lines changed: 42 additions & 15 deletions

File tree

java-cloud-bom/dashboard/pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@
3131
<maven.compiler.source>1.8</maven.compiler.source>
3232
<maven.compiler.target>1.8</maven.compiler.target>
3333

34+
<maven.deploy.skip>true</maven.deploy.skip>
35+
<checkstyle.skip>true</checkstyle.skip>
3436
<guava.version>33.6.0-jre</guava.version>
3537
</properties>
3638

java-cloud-bom/dashboard/src/main/java/com/google/cloud/tools/opensource/cloudbomdashboard/ArtifactResults.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,9 @@ void addResult(String testName, int failures) {
4141
results.put(testName, failures);
4242
}
4343

44-
/** @return true for pass, false for fail, null for unknown test */
44+
/**
45+
* @return true for pass, false for fail, null for unknown test
46+
*/
4547
@Nullable
4648
public Boolean getResult(String testName) {
4749
Integer failures = results.get(testName);
@@ -55,13 +57,17 @@ public String getCoordinates() {
5557
return Artifacts.toCoordinates(artifact);
5658
}
5759

58-
/** @return message of exception occurred when running test, null for no exception */
60+
/**
61+
* @return message of exception occurred when running test, null for no exception
62+
*/
5963
@Nullable
6064
public String getExceptionMessage() {
6165
return exceptionMessage;
6266
}
6367

64-
/** @return number of times the specified test failed. Returns 0 if the test was not run. */
68+
/**
69+
* @return number of times the specified test failed. Returns 0 if the test was not run.
70+
*/
6571
public int getFailureCount(String testName) {
6672
Integer failures = results.get(testName);
6773
if (failures == null) {

java-cloud-bom/dashboard/src/main/java/com/google/cloud/tools/opensource/cloudbomdashboard/DashboardMain.java

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,12 @@ public class DashboardMain {
8888
* snapshot version.
8989
*/
9090
public static void main(String[] arguments)
91-
throws IOException, TemplateException, RepositoryException, URISyntaxException,
92-
ParseException, MavenRepositoryException {
91+
throws IOException,
92+
TemplateException,
93+
RepositoryException,
94+
URISyntaxException,
95+
ParseException,
96+
MavenRepositoryException {
9397
DashboardArguments dashboardArguments = DashboardArguments.readCommandLine(arguments);
9498

9599
// If looking to edit the dashboard structure, see DashboardMain#generateDashboard.
@@ -130,7 +134,10 @@ public static void main(String[] arguments)
130134
}
131135

132136
private static void generateAllVersions(String versionlessCoordinates)
133-
throws IOException, TemplateException, RepositoryException, URISyntaxException,
137+
throws IOException,
138+
TemplateException,
139+
RepositoryException,
140+
URISyntaxException,
134141
MavenRepositoryException {
135142
List<String> elements = Splitter.on(':').splitToList(versionlessCoordinates);
136143
checkArgument(

java-cloud-bom/libraries-release-data/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
2323
<maven.compiler.source>1.8</maven.compiler.source>
2424
<maven.compiler.target>1.8</maven.compiler.target>
25+
<checkstyle.skip>true</checkstyle.skip>
2526
</properties>
2627

2728
<build>

java-cloud-bom/pom.xml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,17 @@
2727
</license>
2828
</licenses>
2929
<modules>
30-
<!-- Only modules to be published to Maven Central. No tests or release note generation. -->
30+
<!-- Modules in the reactor. -->
3131
<module>google-cloud-bom</module>
3232
<module>libraries-bom</module>
33+
34+
<!-- maven.deploy.skip is set to true in the following modules so that they are not published to Maven Central -->
35+
<module>dashboard</module>
36+
<module>release-note-generation</module>
37+
<module>libraries-release-data</module>
38+
<module>tests</module>
39+
<module>tests/dependency-convergence</module>
40+
<module>tests/validate-bom</module>
3341
</modules>
3442

3543
<build>

java-cloud-bom/release-note-generation/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
1919
<maven.compiler.source>11</maven.compiler.source>
2020
<maven.compiler.target>11</maven.compiler.target>
21+
<checkstyle.skip>true</checkstyle.skip>
2122
</properties>
2223

2324
<dependencies>

java-cloud-bom/tests/dependency-convergence/pom.xml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@
1313
<organization>
1414
<name>Google</name>
1515
</organization>
16+
<properties>
17+
<maven.deploy.skip>true</maven.deploy.skip>
18+
<checkstyle.skip>true</checkstyle.skip>
19+
</properties>
1620
<licenses>
1721
<license>
1822
<name>Google Cloud Software License</name>
@@ -151,10 +155,7 @@
151155
<artifactId>google-cloud-dataplex</artifactId>
152156
<groupId>com.google.cloud</groupId>
153157
</dependency>
154-
<dependency>
155-
<artifactId>google-cloud-debugger-client</artifactId>
156-
<groupId>com.google.cloud</groupId>
157-
</dependency>
158+
158159
<dependency>
159160
<artifactId>google-cloud-deploy</artifactId>
160161
<groupId>com.google.cloud</groupId>
@@ -326,10 +327,7 @@
326327
<artifactId>google-cloud-redis</artifactId>
327328
<groupId>com.google.cloud</groupId>
328329
</dependency>
329-
<dependency>
330-
<artifactId>google-cloud-resource-settings</artifactId>
331-
<groupId>com.google.cloud</groupId>
332-
</dependency>
330+
333331
<dependency>
334332
<artifactId>google-cloud-resourcemanager</artifactId>
335333
<groupId>com.google.cloud</groupId>

java-cloud-bom/tests/pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
2323
<maven.compiler.target>1.8</maven.compiler.target>
2424
<maven.compiler.source>1.8</maven.compiler.source>
25+
<maven.deploy.skip>true</maven.deploy.skip>
26+
<checkstyle.skip>true</checkstyle.skip>
2527
</properties>
2628
<licenses>
2729
<license>

java-cloud-bom/tests/validate-bom/pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
2020
<maven.compiler.source>11</maven.compiler.source>
2121
<maven.compiler.target>11</maven.compiler.target>
22+
<maven.deploy.skip>true</maven.deploy.skip>
23+
<checkstyle.skip>true</checkstyle.skip>
2224
</properties>
2325

2426
<dependencies>

0 commit comments

Comments
 (0)