Run google-java-format on all artifacts (#4121)

* Run google-java-format on all artifats

* Format some missed files

* Add more missed files

* Fix formatting issues from the merge

Author: chingor13

google-cloud-datastore/src/main/java/com/google/cloud/datastore/BaseDatastoreBatchWriter.java

@@ -19,7 +19,6 @@
 import com.google.common.base.Preconditions;
 import com.google.common.collect.Iterables;
 import com.google.common.collect.Lists;
-
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Iterator;
@@ -30,9 +29,7 @@
 import java.util.Map;
 import java.util.Set;
 
-/**
- * Base class for DatastoreBatchWriter.
- */
+/** Base class for DatastoreBatchWriter. */
 public abstract class BaseDatastoreBatchWriter implements DatastoreBatchWriter {
 
   private final String name;
@@ -65,8 +62,8 @@ public final void addWithDeferredIdAllocation(FullEntity<?>... entities) {
   private void addInternal(FullEntity<Key> entity) {
     Key key = entity.getKey();
     if (toAdd.containsKey(key) || toUpdate.containsKey(key) || toPut.containsKey(key)) {
-      throw newInvalidRequest("Entity with the key %s was already added or updated in this %s",
-          entity.getKey(), name);
+      throw newInvalidRequest(
+          "Entity with the key %s was already added or updated in this %s", entity.getKey(), name);
     }
     if (toDelete.remove(key)) {
       toPut.put(key, entity);
@@ -120,8 +117,8 @@ public final void update(Entity... entities) {
     for (Entity entity : entities) {
       Key key = entity.getKey();
       if (toDelete.contains(key)) {
-        throw newInvalidRequest("Entity with the key %s was already deleted in this %s",
-            entity.getKey(), name);
+        throw newInvalidRequest(
+            "Entity with the key %s was already deleted in this %s", entity.getKey(), name);
       }
       if (toAdd.remove(key) != null || toPut.containsKey(key)) {
         toPut.put(key, entity);
@@ -203,7 +200,6 @@ public final void delete(Key... keys) {
     }
   }
 
-
   @Override
   public boolean isActive() {
     return active;
@@ -271,6 +267,5 @@ protected List<com.google.datastore.v1.Mutation> toMutationPbList() {
     return mutationsPb;
   }
 
-
   protected abstract Datastore getDatastore();
 }

google-cloud-datastore/src/main/java/com/google/cloud/datastore/BaseEntity.java

@@ -18,7 +18,6 @@
 
 import static com.google.cloud.datastore.BlobValue.of;
 import static com.google.cloud.datastore.BooleanValue.of;
-import static com.google.cloud.datastore.TimestampValue.of;
 import static com.google.cloud.datastore.DoubleValue.of;
 import static com.google.cloud.datastore.EntityValue.of;
 import static com.google.cloud.datastore.KeyValue.of;
@@ -27,12 +26,12 @@
 import static com.google.cloud.datastore.LongValue.of;
 import static com.google.cloud.datastore.NullValue.of;
 import static com.google.cloud.datastore.StringValue.of;
+import static com.google.cloud.datastore.TimestampValue.of;
 
 import com.google.cloud.Timestamp;
 import com.google.common.base.MoreObjects;
 import com.google.common.collect.ImmutableSortedMap;
 import com.google.common.collect.Maps;
-
 import java.io.Serializable;
 import java.util.HashMap;
 import java.util.LinkedList;
@@ -42,11 +41,10 @@
 import java.util.Set;
 
 /**
- * A base class for entities (key and properties).
- * An entity is a Google Cloud Datastore persistent data object.
- * An entity holds one or more properties, represented by a name (as {@link String})
- * and a value (as {@link com.google.cloud.datastore.Value}), and may be associated with a
- * key. For a list of possible values see {@link ValueType}.
+ * A base class for entities (key and properties). An entity is a Google Cloud Datastore persistent
+ * data object. An entity holds one or more properties, represented by a name (as {@link String})
+ * and a value (as {@link com.google.cloud.datastore.Value}), and may be associated with a key. For
+ * a list of possible values see {@link ValueType}.
  *
  * @see <a href="https://cloud.google.com/datastore/docs/concepts/entities">Google Cloud Datastore
  *     Entities, Properties, and Keys</a>
@@ -62,8 +60,7 @@ public abstract static class Builder<K extends IncompleteKey, B extends Builder<
     private K key;
     private final Map<String, Value<?>> properties = new HashMap<>();
 
-    Builder() {
-    }
+    Builder() {}
 
     Builder(K key) {
       setKey(key);
@@ -110,26 +107,19 @@ protected B setProperties(Map<String, Value<?>> properties) {
       return self();
     }
 
-
-    /**
-     * Sets the key for the entity.
-     */
+    /** Sets the key for the entity. */
     public B setKey(K key) {
       this.key = key;
       return self();
     }
 
-    /**
-     * Clears all the properties.
-     */
+    /** Clears all the properties. */
     public B clear() {
       properties.clear();
       return self();
     }
 
-    /**
-     * Removes a property with the given {@code name}.
-     */
+    /** Removes a property with the given {@code name}. */
     public B remove(String name) {
       properties.remove(name);
       return self();
@@ -485,28 +475,20 @@ public boolean equals(Object obj) {
       return false;
     }
     BaseEntity<?> other = (BaseEntity<?>) obj;
-    return Objects.equals(key, other.key)
-        && Objects.equals(properties, other.properties);
+    return Objects.equals(key, other.key) && Objects.equals(properties, other.properties);
   }
 
-  /**
-   * Returns true if entity has a non-null key.
-   */
+  /** Returns true if entity has a non-null key. */
   public boolean hasKey() {
     return key != null;
   }
 
-
-  /**
-   * Returns the associated key or null if it does not have one.
-   */
+  /** Returns the associated key or null if it does not have one. */
   public K getKey() {
     return key;
   }
 
-  /**
-   * Returns {@code true} if the entity contains a property with the given {@code name}.
-   */
+  /** Returns {@code true} if the entity contains a property with the given {@code name}. */
   public boolean contains(String name) {
     return properties.containsKey(name);
   }
@@ -534,7 +516,6 @@ public boolean isNull(String name) {
     return getValue(name) instanceof NullValue;
   }
 
-
   /**
    * Returns the property value as a string.
    *
@@ -645,10 +626,7 @@ public Blob getBlob(String name) {
     return ((Value<Blob>) getValue(name)).get();
   }
 
-
-  /**
-   * Returns the properties name.
-   */
+  /** Returns the properties name. */
   public Set<String> getNames() {
     return properties.keySet();
   }

google-cloud-datastore/src/main/java/com/google/cloud/datastore/BaseKey.java

@@ -23,15 +23,12 @@
 import com.google.common.base.MoreObjects;
 import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableList;
-
 import java.io.Serializable;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Objects;
 
-/**
- * Base class for keys.
- */
+/** Base class for keys. */
 public abstract class BaseKey implements Serializable {
 
   private static final long serialVersionUID = -5897863400209818325L;
@@ -76,58 +73,40 @@ B self() {
       return (B) this;
     }
 
-
-    /**
-     * Adds an ancestor for this key.
-     */
+    /** Adds an ancestor for this key. */
     public B addAncestor(PathElement ancestor) {
       Preconditions.checkState(ancestors.size() < MAX_PATH, "path can have at most 100 elements");
       ancestors.add(ancestor);
       return self();
     }
 
-
-    /**
-     * Adds the provided ancestors to the key.
-     */
+    /** Adds the provided ancestors to the key. */
     public B addAncestors(PathElement ancestor, PathElement... other) {
       return addAncestors(ImmutableList.<PathElement>builder().add(ancestor).add(other).build());
     }
 
-
-    /**
-     * Adds the provided ancestors to the key.
-     */
+    /** Adds the provided ancestors to the key. */
     public B addAncestors(Iterable<PathElement> ancestors) {
       ImmutableList<PathElement> list = ImmutableList.copyOf(ancestors);
-      Preconditions.checkState(this.ancestors.size() + list.size() < MAX_PATH,
-          "path can have at most 100 elements");
+      Preconditions.checkState(
+          this.ancestors.size() + list.size() < MAX_PATH, "path can have at most 100 elements");
       this.ancestors.addAll(list);
       return self();
     }
 
-
-    /**
-     * Sets the kind of the key.
-     */
+    /** Sets the kind of the key. */
     public B setKind(String kind) {
       this.kind = validateKind(kind);
       return self();
     }
 
-
-    /**
-     * Sets the project ID of the key.
-     */
+    /** Sets the project ID of the key. */
     public B setProjectId(String projectId) {
       this.projectId = validateDatabase(projectId);
       return self();
     }
 
-
-    /**
-     * Sets the namespace of the key.
-     */
+    /** Sets the namespace of the key. */
     public B setNamespace(String namespace) {
       this.namespace = validateNamespace(namespace);
       return self();
@@ -143,34 +122,22 @@ public B setNamespace(String namespace) {
     this.path = path;
   }
 
-
-  /**
-   * Returns the key's projectId.
-   */
+  /** Returns the key's projectId. */
   public String getProjectId() {
     return projectId;
   }
 
-
-  /**
-   * Returns the key's namespace or {@code null} if not provided.
-   */
+  /** Returns the key's namespace or {@code null} if not provided. */
   public String getNamespace() {
     return namespace;
   }
 
-
-  /**
-   * Returns an immutable list with the key's ancestors.
-   */
+  /** Returns an immutable list with the key's ancestors. */
   public List<PathElement> getAncestors() {
     return getPath().subList(0, getPath().size() - 1);
   }
 
-
-  /**
-   * Returns an immutable list of the key's path (ancestors + self).
-   */
+  /** Returns an immutable list of the key's path (ancestors + self). */
   List<PathElement> getPath() {
     return path;
   }
@@ -179,15 +146,11 @@ PathElement getLeaf() {
     return getPath().get(getPath().size() - 1);
   }
 
-
-  /**
-   * Returns the key's kind.
-   */
+  /** Returns the key's kind. */
   public String getKind() {
     return getLeaf().getKind();
   }
 
-
   abstract BaseKey getParent();
 
   @Override

google-cloud-datastore/src/main/java/com/google/cloud/datastore/Batch.java

@@ -19,11 +19,10 @@
 import java.util.List;
 
 /**
- * An interface to represent a batch of write operations.
- * Any write operation that is applied on a batch will only be sent
- * to the Datastore upon {@link #submit}.
- * A usage example:
- * <pre> {@code
+ * An interface to represent a batch of write operations. Any write operation that is applied on a
+ * batch will only be sent to the Datastore upon {@link #submit}. A usage example:
+ *
+ * <pre>{@code
  * Entity entity1 = datastore.get(key1);
  * Batch batch = datastore.newBatch();
  * Entity entity2 = Entity.newBuilder(key2).set("name", "John").build();
@@ -32,24 +31,22 @@
  * batch.update(entity1);
  * batch.add(entity2, entity3);
  * batch.submit();
- * } </pre>
+ * }</pre>
  */
 public interface Batch extends DatastoreBatchWriter {
 
   interface Response {
 
-    /**
-     * Returns a list of keys generated by a batch.
-     */
+    /** Returns a list of keys generated by a batch. */
     List<Key> getGeneratedKeys();
   }
 
   /**
    * {@inheritDoc}
    *
    * <p>If an entity for {@code entity.getKey()} does not exists, {@code entity} is inserted.
-   * Otherwise, {@link #submit()} will throw a {@link DatastoreException} with
-   * {@link DatastoreException#getReason()} equal to {@code "ALREADY_EXISTS"}.
+   * Otherwise, {@link #submit()} will throw a {@link DatastoreException} with {@link
+   * DatastoreException#getReason()} equal to {@code "ALREADY_EXISTS"}.
    */
   @Override
   Entity add(FullEntity<?> entity);
@@ -58,9 +55,9 @@ interface Response {
    * {@inheritDoc}
    *
    * <p>If none of entities' keys exist, all entities are inserted. If any of entities' keys already
-   * exists, {@link #submit()} will throw a {@link DatastoreException} with
-   * {@link DatastoreException#getReason()} equal to {@code "ALREADY_EXISTS"}. All entities in
-   * {@code entities} whose key did not exist are inserted.
+   * exists, {@link #submit()} will throw a {@link DatastoreException} with {@link
+   * DatastoreException#getReason()} equal to {@code "ALREADY_EXISTS"}. All entities in {@code
+   * entities} whose key did not exist are inserted.
    */
   @Override
   List<Entity> add(FullEntity<?>... entities);
@@ -72,9 +69,6 @@ interface Response {
    */
   Response submit();
 
-
-  /**
-   * Returns the batch associated {@link Datastore}.
-   */
+  /** Returns the batch associated {@link Datastore}. */
   Datastore getDatastore();
 }