Skip to content

Commit 41036ec

Browse files
committed
Hide string setter for DeprecationStatus timestamps
1 parent 0f59ac5 commit 41036ec

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

gcloud-java-compute/src/main/java/com/google/cloud/compute/DeprecationStatus.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,8 @@ public static final class Builder<T extends ResourceId> {
9696
*
9797
* @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>
9898
*/
99-
// todo(mziccard): remove this method if #732 is closed
100-
public Builder<T> deleted(String deleted) {
99+
// Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)
100+
Builder<T> deleted(String deleted) {
101101
this.deleted = deleted;
102102
return this;
103103
}
@@ -108,8 +108,8 @@ public Builder<T> deleted(String deleted) {
108108
*
109109
* @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>
110110
*/
111-
// todo(mziccard): remove this method if #732 is closed
112-
public Builder<T> deprecated(String deprecated) {
111+
// Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)
112+
Builder<T> deprecated(String deprecated) {
113113
this.deprecated = deprecated;
114114
return this;
115115
}
@@ -120,8 +120,8 @@ public Builder<T> deprecated(String deprecated) {
120120
*
121121
* @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>
122122
*/
123-
// todo(mziccard): remove this method if #732 is closed
124-
public Builder<T> obsolete(String obsolete) {
123+
// Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)
124+
Builder<T> obsolete(String obsolete) {
125125
this.obsolete = obsolete;
126126
return this;
127127
}
@@ -193,7 +193,7 @@ public DeprecationStatus<T> build() {
193193
*
194194
* @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>
195195
*/
196-
// todo(mziccard): remove this method if #732 is closed
196+
// Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)
197197
public String deleted() {
198198
return deleted;
199199
}
@@ -205,7 +205,7 @@ public String deleted() {
205205
*
206206
* @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>
207207
*/
208-
// todo(mziccard): remove this method if #732 is closed
208+
// Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)
209209
public String deprecated() {
210210
return deprecated;
211211
}
@@ -217,7 +217,7 @@ public String deprecated() {
217217
*
218218
* @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>
219219
*/
220-
// todo(mziccard): remove this method if #732 is closed
220+
// Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)
221221
public String obsolete() {
222222
return obsolete;
223223
}

0 commit comments

Comments
 (0)