Skip to content

Commit 30d91cf

Browse files
committed
Merge pull request #141 from aozarov/temp1
Enable running against gcloud datastore emulator (using DATASTORE_HOST)
2 parents 8ead095 + 9b10a14 commit 30d91cf

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

gcloud-java-core/src/main/java/com/google/gcloud/ServiceOptions.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ public B serviceRpcFactory(ServiceRpcFactory<ServiceRpcT, OptionsT> serviceRpcFa
154154

155155
protected ServiceOptions(Builder<ServiceRpcT, OptionsT, ?> builder) {
156156
projectId = checkNotNull(builder.projectId != null ? builder.projectId : defaultProject());
157-
host = firstNonNull(builder.host, DEFAULT_HOST);
157+
host = firstNonNull(builder.host, defaultHost());
158158
httpTransportFactory =
159159
firstNonNull(builder.httpTransportFactory, DefaultHttpTransportFactory.INSTANCE);
160160
authCredentials = firstNonNull(builder.authCredentials, defaultAuthCredentials());
@@ -191,6 +191,10 @@ protected static String appEngineAppId() {
191191
return System.getProperty("com.google.appengine.application.id");
192192
}
193193

194+
protected String defaultHost() {
195+
return DEFAULT_HOST;
196+
}
197+
194198
protected String defaultProject() {
195199
String projectId = System.getProperty(PROJECT_ENV_NAME, System.getenv(PROJECT_ENV_NAME));
196200
if (projectId == null) {

gcloud-java-datastore/src/main/java/com/google/gcloud/datastore/DatastoreOptions.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ public class DatastoreOptions extends ServiceOptions<DatastoreRpc, DatastoreOpti
3838

3939
private static final long serialVersionUID = -8636602944160689193L;
4040
private static final String DATASET_ENV_NAME = "DATASTORE_DATASET";
41+
private static final String HOST_ENV_NAME = "DATASTORE_HOST";
4142
private static final String DATASTORE_SCOPE = "https://www.googleapis.com/auth/datastore";
4243
private static final String USERINFO_SCOPE = "https://www.googleapis.com/auth/userinfo.email";
4344
private static final Set<String> SCOPES = ImmutableSet.of(DATASTORE_SCOPE, USERINFO_SCOPE);
@@ -122,6 +123,12 @@ private DatastoreOptions normalize() {
122123
}
123124
}
124125

126+
@Override
127+
protected String defaultHost() {
128+
String host = System.getProperty(HOST_ENV_NAME, System.getenv(HOST_ENV_NAME));
129+
return host != null ? host : super.defaultHost();
130+
}
131+
125132
@Override
126133
protected String defaultProject() {
127134
String projectId = System.getProperty(DATASET_ENV_NAME, System.getenv(DATASET_ENV_NAME));

0 commit comments

Comments
 (0)