Skip to content

Commit 28f216e

Browse files
Removing devtools from package, refreshing tests
1 parent 6c521c1 commit 28f216e

18 files changed

+111
-55
lines changed

gcloud-java-core/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@
106106
<dependency>
107107
<groupId>com.google.api</groupId>
108108
<artifactId>gax</artifactId>
109-
<version>0.0.15</version>
109+
<version>0.0.16</version>
110110
</dependency>
111111
<dependency>
112112
<groupId>com.google.api.grpc</groupId>

gcloud-java-errorreporting/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<parent>
1212
<groupId>com.google.cloud</groupId>
1313
<artifactId>gcloud-java-pom</artifactId>
14-
<version>0.2.8-SNAPSHOT</version>
14+
<version>0.2.9-SNAPSHOT</version>
1515
</parent>
1616
<properties>
1717
<site.installationModule>gcloud-java-errorreporting</site.installationModule>

gcloud-java-errorreporting/src/main/java/com/google/cloud/devtools/clouderrorreporting/spi/v1beta1/ErrorGroupServiceApi.java renamed to gcloud-java-errorreporting/src/main/java/com/google/cloud/errorreporting/spi/v1beta1/ErrorGroupServiceApi.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
* or implied. See the License for the specific language governing permissions and limitations under
1212
* the License.
1313
*/
14-
package com.google.cloud.devtools.clouderrorreporting.spi.v1beta1;
14+
package com.google.cloud.errorreporting.spi.v1beta1;
1515

1616
import com.google.api.gax.grpc.ApiCallable;
1717
import com.google.api.gax.protobuf.PathTemplate;

gcloud-java-errorreporting/src/main/java/com/google/cloud/devtools/clouderrorreporting/spi/v1beta1/ErrorGroupServiceSettings.java renamed to gcloud-java-errorreporting/src/main/java/com/google/cloud/errorreporting/spi/v1beta1/ErrorGroupServiceSettings.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
* or implied. See the License for the specific language governing permissions and limitations under
1212
* the License.
1313
*/
14-
package com.google.cloud.devtools.clouderrorreporting.spi.v1beta1;
14+
package com.google.cloud.errorreporting.spi.v1beta1;
1515

1616
import com.google.api.gax.core.ConnectionSettings;
1717
import com.google.api.gax.core.RetrySettings;

gcloud-java-errorreporting/src/main/java/com/google/cloud/devtools/clouderrorreporting/spi/v1beta1/ErrorStatsServiceApi.java renamed to gcloud-java-errorreporting/src/main/java/com/google/cloud/errorreporting/spi/v1beta1/ErrorStatsServiceApi.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
* or implied. See the License for the specific language governing permissions and limitations under
1212
* the License.
1313
*/
14-
package com.google.cloud.devtools.clouderrorreporting.spi.v1beta1;
14+
package com.google.cloud.errorreporting.spi.v1beta1;
1515

1616
import com.google.api.gax.core.PageAccessor;
1717
import com.google.api.gax.grpc.ApiCallable;

gcloud-java-errorreporting/src/main/java/com/google/cloud/devtools/clouderrorreporting/spi/v1beta1/ErrorStatsServiceSettings.java renamed to gcloud-java-errorreporting/src/main/java/com/google/cloud/errorreporting/spi/v1beta1/ErrorStatsServiceSettings.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
* or implied. See the License for the specific language governing permissions and limitations under
1212
* the License.
1313
*/
14-
package com.google.cloud.devtools.clouderrorreporting.spi.v1beta1;
14+
package com.google.cloud.errorreporting.spi.v1beta1;
1515

1616
import com.google.api.gax.core.ConnectionSettings;
1717
import com.google.api.gax.core.RetrySettings;

gcloud-java-errorreporting/src/main/java/com/google/cloud/devtools/clouderrorreporting/spi/v1beta1/ReportErrorsServiceApi.java renamed to gcloud-java-errorreporting/src/main/java/com/google/cloud/errorreporting/spi/v1beta1/ReportErrorsServiceApi.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
* or implied. See the License for the specific language governing permissions and limitations under
1212
* the License.
1313
*/
14-
package com.google.cloud.devtools.clouderrorreporting.spi.v1beta1;
14+
package com.google.cloud.errorreporting.spi.v1beta1;
1515

1616
import com.google.api.gax.grpc.ApiCallable;
1717
import com.google.api.gax.protobuf.PathTemplate;

gcloud-java-errorreporting/src/main/java/com/google/cloud/devtools/clouderrorreporting/spi/v1beta1/ReportErrorsServiceSettings.java renamed to gcloud-java-errorreporting/src/main/java/com/google/cloud/errorreporting/spi/v1beta1/ReportErrorsServiceSettings.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
* or implied. See the License for the specific language governing permissions and limitations under
1212
* the License.
1313
*/
14-
package com.google.cloud.devtools.clouderrorreporting.spi.v1beta1;
14+
package com.google.cloud.errorreporting.spi.v1beta1;
1515

1616
import com.google.api.gax.core.ConnectionSettings;
1717
import com.google.api.gax.core.RetrySettings;

gcloud-java-errorreporting/src/main/java/com/google/cloud/devtools/clouderrorreporting/spi/v1beta1/package-info.java renamed to gcloud-java-errorreporting/src/main/java/com/google/cloud/errorreporting/spi/v1beta1/package-info.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,4 +68,4 @@
6868
* </pre>
6969
*
7070
*/
71-
package com.google.cloud.devtools.clouderrorreporting.spi.v1beta1;
71+
package com.google.cloud.errorreporting.spi.v1beta1;

gcloud-java-errorreporting/src/test/java/com/google/cloud/devtools/clouderrorreporting/spi/v1beta1/ErrorGroupServiceTest.java renamed to gcloud-java-errorreporting/src/test/java/com/google/cloud/errorreporting/spi/v1beta1/ErrorGroupServiceTest.java

Lines changed: 28 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
* the License.
1313
*/
1414

15-
package com.google.cloud.devtools.clouderrorreporting.spi.v1beta1;
15+
package com.google.cloud.errorreporting.spi.v1beta1;
1616

1717
import com.google.api.gax.core.PageAccessor;
1818
import com.google.api.gax.testing.MockGrpcService;
@@ -24,23 +24,33 @@
2424
import com.google.protobuf.GeneratedMessage;
2525
import java.io.IOException;
2626
import java.util.ArrayList;
27+
import java.util.Arrays;
2728
import java.util.List;
28-
import junit.framework.Assert;
2929
import org.junit.After;
3030
import org.junit.AfterClass;
31+
import org.junit.Assert;
3132
import org.junit.Before;
3233
import org.junit.BeforeClass;
3334
import org.junit.Test;
3435

3536
@javax.annotation.Generated("by GAPIC")
3637
public class ErrorGroupServiceTest {
38+
private static MockErrorGroupService mockErrorGroupService;
39+
private static MockErrorStatsService mockErrorStatsService;
40+
private static MockReportErrorsService mockReportErrorsService;
3741
private static MockServiceHelper serviceHelper;
3842
private ErrorGroupServiceApi api;
3943

4044
@BeforeClass
4145
public static void startStaticServer() {
42-
MockErrorGroupService mockService = new MockErrorGroupService();
43-
serviceHelper = new MockServiceHelper("in-process-1", mockService);
46+
mockErrorGroupService = new MockErrorGroupService();
47+
mockErrorStatsService = new MockErrorStatsService();
48+
mockReportErrorsService = new MockReportErrorsService();
49+
serviceHelper =
50+
new MockServiceHelper(
51+
"in-process-1",
52+
Arrays.<MockGrpcService>asList(
53+
mockErrorGroupService, mockErrorStatsService, mockReportErrorsService));
4454
serviceHelper.start();
4555
}
4656

@@ -67,38 +77,44 @@ public void tearDown() throws Exception {
6777
@Test
6878
@SuppressWarnings("all")
6979
public void getGroupTest() {
70-
ErrorGroup expectedResponse = ErrorGroup.newBuilder().build();
80+
String name = "name3373707";
81+
String groupId = "groupId506361563";
82+
ErrorGroup expectedResponse = ErrorGroup.newBuilder().setName(name).setGroupId(groupId).build();
7183
List<GeneratedMessage> expectedResponses = new ArrayList<>();
7284
expectedResponses.add(expectedResponse);
73-
serviceHelper.getService().setResponses(expectedResponses);
85+
mockErrorGroupService.setResponses(expectedResponses);
7486

7587
String formattedGroupName = ErrorGroupServiceApi.formatGroupName("[PROJECT]", "[GROUP]");
88+
7689
ErrorGroup actualResponse = api.getGroup(formattedGroupName);
7790
Assert.assertEquals(expectedResponse, actualResponse);
7891

79-
List<GeneratedMessage> actualRequests = serviceHelper.getService().getRequests();
92+
List<GeneratedMessage> actualRequests = mockErrorGroupService.getRequests();
8093
Assert.assertEquals(1, actualRequests.size());
8194
GetGroupRequest actualRequest = (GetGroupRequest) actualRequests.get(0);
8295

83-
Assert.assertEquals(actualRequest.getGroupName(), formattedGroupName);
96+
Assert.assertEquals(formattedGroupName, actualRequest.getGroupName());
8497
}
8598

8699
@Test
87100
@SuppressWarnings("all")
88101
public void updateGroupTest() {
89-
ErrorGroup expectedResponse = ErrorGroup.newBuilder().build();
102+
String name = "name3373707";
103+
String groupId = "groupId506361563";
104+
ErrorGroup expectedResponse = ErrorGroup.newBuilder().setName(name).setGroupId(groupId).build();
90105
List<GeneratedMessage> expectedResponses = new ArrayList<>();
91106
expectedResponses.add(expectedResponse);
92-
serviceHelper.getService().setResponses(expectedResponses);
107+
mockErrorGroupService.setResponses(expectedResponses);
93108

94109
ErrorGroup group = ErrorGroup.newBuilder().build();
110+
95111
ErrorGroup actualResponse = api.updateGroup(group);
96112
Assert.assertEquals(expectedResponse, actualResponse);
97113

98-
List<GeneratedMessage> actualRequests = serviceHelper.getService().getRequests();
114+
List<GeneratedMessage> actualRequests = mockErrorGroupService.getRequests();
99115
Assert.assertEquals(1, actualRequests.size());
100116
UpdateGroupRequest actualRequest = (UpdateGroupRequest) actualRequests.get(0);
101117

102-
Assert.assertEquals(actualRequest.getGroup(), group);
118+
Assert.assertEquals(group, actualRequest.getGroup());
103119
}
104120
}

0 commit comments

Comments
 (0)