Skip to content

Commit 1fb53fa

Browse files
committed
Remove redundant parameter from configuration Builder constructor
1 parent 094c3b3 commit 1fb53fa

File tree

7 files changed

+9
-9
lines changed

7 files changed

+9
-9
lines changed

gcloud-java-compute/src/main/java/com/google/gcloud/compute/DiskConfiguration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ public abstract static class Builder<T extends DiskConfiguration, B extends Buil
7676
this.type = type;
7777
}
7878

79-
Builder(Type type, DiskConfiguration diskConfiguration) {
80-
this.type = type;
79+
Builder(DiskConfiguration diskConfiguration) {
80+
this.type = diskConfiguration.type;
8181
this.sizeGb = diskConfiguration.sizeGb;
8282
this.diskType = diskConfiguration.diskType;
8383
}

gcloud-java-compute/src/main/java/com/google/gcloud/compute/DiskImageConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ private Builder() {
4848
}
4949

5050
private Builder(DiskImageConfiguration imageConfiguration) {
51-
super(Type.DISK, imageConfiguration);
51+
super(imageConfiguration);
5252
this.sourceDisk = imageConfiguration.sourceDisk;
5353
this.sourceDiskId = imageConfiguration.sourceDiskId;
5454
}

gcloud-java-compute/src/main/java/com/google/gcloud/compute/ImageConfiguration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,8 @@ public abstract static class Builder<T extends ImageConfiguration, B extends Bui
7373
this.type = type;
7474
}
7575

76-
Builder(Type type, ImageConfiguration imageConfiguration) {
77-
this.type = type;
76+
Builder(ImageConfiguration imageConfiguration) {
77+
this.type = imageConfiguration.type;
7878
this.sourceType = imageConfiguration.sourceType;
7979
this.archiveSizeBytes = imageConfiguration.archiveSizeBytes;
8080
}

gcloud-java-compute/src/main/java/com/google/gcloud/compute/ImageDiskConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ private Builder() {
4949
}
5050

5151
private Builder(ImageDiskConfiguration configuration) {
52-
super(Type.IMAGE, configuration);
52+
super(configuration);
5353
this.sourceImage = configuration.sourceImage;
5454
this.sourceImageId = configuration.sourceImageId;
5555
}

gcloud-java-compute/src/main/java/com/google/gcloud/compute/SnapshotDiskConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ private Builder() {
5050
}
5151

5252
private Builder(SnapshotDiskConfiguration configuration) {
53-
super(Type.SNAPSHOT, configuration);
53+
super(configuration);
5454
this.sourceSnapshot = configuration.sourceSnapshot;
5555
this.sourceSnapshotId = configuration.sourceSnapshotId;
5656
}

gcloud-java-compute/src/main/java/com/google/gcloud/compute/StandardDiskConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ private Builder() {
4141
}
4242

4343
private Builder(StandardDiskConfiguration configuration) {
44-
super(Type.STANDARD, configuration);
44+
super(configuration);
4545
}
4646

4747
private Builder(Disk diskPb) {

gcloud-java-compute/src/main/java/com/google/gcloud/compute/StorageImageConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ private Builder() {
5858
}
5959

6060
private Builder(StorageImageConfiguration imageConfiguration) {
61-
super(Type.STORAGE, imageConfiguration);
61+
super(imageConfiguration);
6262
this.containerType = imageConfiguration.containerType;
6363
this.sha1 = imageConfiguration.sha1;
6464
this.source = imageConfiguration.source;

0 commit comments

Comments
 (0)