Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accesscontextmanager: missing field scopes[] #6922

Closed
mrbuk opened this issue Oct 25, 2022 · 6 comments
Closed

accesscontextmanager: missing field scopes[] #6922

mrbuk opened this issue Oct 25, 2022 · 6 comments
Assignees
Labels
api: accesscontextmanager Issues related to the Access Context Manager API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@mrbuk
Copy link

mrbuk commented Oct 25, 2022

Client

Access Context Manager API

Expected behavior

Access Policy RPC Reference contains field "scopes".

Actual behavior

Field is missing in Go definition and protoc file but is transmitted as an unknown field 7:

log.Printf("%+v", resp):

    name:"accessPolicies/93646629123"  
    parent:"organizations/321904912434"  
    title:"policy-01"  
    etag:"aaaa296555512723"  
    7:"projects/1281568631231"

Field is correctly returned by gcloud

$ gcloud access-context-manager policies list --organization=321904912434 --format json
  {
    "etag": "aaaa296555512723",
    "name": "accessPolicies/93646629123",
    "parent": "organizations/321904912434",
    "scopes": [
      "projects/1281568631231"
    ],
    "title": "policy-01"
  }

Additional context

The field is only populated in case a scoped policy exists in the Google Cloud Organization (non default policy)

@mrbuk mrbuk added the triage me I really want to be triaged. label Oct 25, 2022
@product-auto-label product-auto-label bot added the api: accesscontextmanager Issues related to the Access Context Manager API. label Oct 25, 2022
@quartzmo quartzmo added the type: question Request for information or clarification. Not an issue. label Oct 26, 2022
@quartzmo quartzmo self-assigned this Oct 26, 2022
@quartzmo
Copy link
Member

@mrbuk Thank you for reporting this. The published file is indeed stale and needs to be updated. I'll post here once I can confirm that it has been done.

@quartzmo quartzmo added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed type: question Request for information or clarification. Not an issue. triage me I really want to be triaged. labels Oct 28, 2022
@mrbuk
Copy link
Author

mrbuk commented Nov 7, 2022

Sure thing @quartzmo. I would have created a PR but I was not sure where / how you do the generation from.

If you point me to docs I am happy to create the PR. If not I am also happy to wait.

@quartzmo
Copy link
Member

quartzmo commented Nov 8, 2022

The change is now making its way through the automated pipeline. I'll post links here when progress is visible on GitHub. Thanks for your patience!!

@quartzmo
Copy link
Member

quartzmo commented Nov 9, 2022

scopes will be added here in #7005.

@quartzmo
Copy link
Member

@mrbuk
Copy link
Author

mrbuk commented Nov 19, 2022

Validated and works as expected for me. Thanks for the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: accesscontextmanager Issues related to the Access Context Manager API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants