Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firestore: add tracing to GetAll method #4203

Open
crwilcox opened this issue Jun 2, 2021 · 0 comments
Open

firestore: add tracing to GetAll method #4203

crwilcox opened this issue Jun 2, 2021 · 0 comments
Assignees
@bhshkh
Labels
api: firestore Issues related to the Firestore API. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@crwilcox
Copy link
Contributor

crwilcox commented Jun 2, 2021

func (it *DocumentIterator) GetAll() ([]*DocumentSnapshot, error) { doesn't have tracing but it could be useful for understanding time to retrieve all documents in tracing.

Currently there isn't a straightforward way to get the ctx which would be needed for tracing as the iterator is behind an interface without ctx.

This work would require exposing the ctx either via the interface. Or perhaps context.Background could be used?
@crwilcox crwilcox added the triage me I really want to be triaged. label Jun 2, 2021
@product-auto-label product-auto-label bot added the api: firestore Issues related to the Firestore API. label Jun 2, 2021
@crwilcox crwilcox added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed api: firestore Issues related to the Firestore API. triage me I really want to be triaged. labels Jun 2, 2021
@product-auto-label product-auto-label bot added the api: firestore Issues related to the Firestore API. label Jun 3, 2021
@telpirion telpirion self-assigned this Sep 23, 2022
@telpirion telpirion added the next major: breaking change this is a change that we should wait to bundle into the next major version label Sep 23, 2022
@telpirion telpirion assigned triplequark and unassigned telpirion Nov 4, 2022
@bhshkh bhshkh assigned bhshkh and unassigned triplequark Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhshkh bhshkh

Labels
api: firestore Issues related to the Firestore API. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@crwilcox @telpirion @bhshkh @triplequark