-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when updating the library with go modules #1359
Comments
Looks like it was fixed in gRPC by grpc/grpc-go#2393 @jadekler we probably still need rev our gRPC dep in a couple more repos? I think go.mod is on grpc v1.19 across the board but not tagged yet in some repos.
|
That said, it's weird that even though grpc@v1.19 is unequivocally used for the build, that the Go tool still uses an older version during |
golang.org/x/lint recently got a go.mod golang/lint@d0100b6. Let's be sure to minimally use this version, since its dependencies are now codified. This may also fix upstream issues we're seeing with gRPC and golang.org/x/lint googleapis/google-cloud-go#1359. This CL was generated by deleting the x/lint line in go.mod and running `go mod tidy`.
gax@v2.0.4 upgrades its grpc dependency from v1.16.0 to v1.19.0: https://github.com/googleapis/gax-go/releases/tag/v2.0.4 golang.org/x/build v0.0.0-20190314133821-5284462c4bec removes an indirect dependency on grpc@v1.16.0: golang/go#30833 This CL was generated by manually deleting the gax and x/build dependencies in go.mod and running `go mod tidy`. This CL will be tagged v0.37.1. Relevant issue: #1359 Change-Id: I68dbfa8b0f58825c74092247a7825a296f3aac79 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/39010 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
Seems to be an issue with how go modules interprets modules whose names have changed (github.com/x/lint and golang.org/x/lint). Tracking discussion in golang/go#30831. |
Since this is a core issue and affects anyone depending on x/lint, I'm closing this in favour of golang/go#30831. |
I know there are multiple tracking issues at this point for the related set of changes, but is there a next step here on this issue? The original symptoms reported here still seem to happen, e.g., as of a few moments ago:
For example, was there a change made to this repo to help, but a tagged release is still pending? golang/go#30831 I think might be more about a medium or long term fix by changing the |
FWIW, the same steps starting with cloud.google.com/go@master also seem to currently fail:
|
I agree that it'd be worth it to re-open this one for tracking things happening in this repository. Any changes in the I've been wanting to try to resolve the issue in |
Because this error occurs: go: github.com/golang/lint@v0.0.0-20190313153728-d0100b6bd8b3: parsing go.mod: unexpected module path "golang.org/x/lint" Many issues which report this kind of error, for example googleapis/google-cloud-go#1359
Ack - re-opening. Update: v0.37.1 released https://github.com/googleapis/google-cloud-go/releases/tag/v0.37.1. This includes several updates to our dependencies. (https://code-review.googlesource.com/c/gocloud/+/3901) Don't think this fixes our problems: continuing to investigate. |
gax@v2.0.4 upgrades its grpc dependency from v1.16.0 to v1.19.0: https://github.com/googleapis/gax-go/releases/tag/v2.0.4 golang.org/x/build v0.0.0-20190314133821-5284462c4bec removes an indirect dependency on grpc@v1.16.0: golang/go#30833 This CL was generated by manually deleting the gax and x/build dependencies in go.mod and running `go mod tidy`. This CL will be tagged v0.37.1. Relevant issue: googleapis#1359 Change-Id: I68dbfa8b0f58825c74092247a7825a296f3aac79 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/39010 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
Any updates on when a fix for this might be out? I need to give my PM a timeline.
|
It's going to require a change in golang/go to fix the underlying problem - that's tracked in golang/go#30831. We (Google library maintainers) are going to do a few moderately complicated tag song-and-dances in the next few weeks to try to alleviate the problem until then. No hard ETA, though. In the meantime, I would try to avoid doing |
This has been fixed. For whichever you depend on, please use:
|
This commit updates the OpenCensus dependency to 0.20.1, fixing a circular dependency (see googleapis/google-cloud-go#1359 (comment)).
Describe Your Environment
Docker, Cloud Shell, vanilla Go installation in an Ubuntu machine, ...
Expected Behavior
Be able to install the library and then update the packages without error.
Actual Behavior
Possibly related to this issue: golang/lint#436 (comment) , but they asked me to open the issue here instead to investigate it.
You can reproduce the error with these commands:
The text was updated successfully, but these errors were encountered: