Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: TestIntegration_SoftDelete failed #10761

Open
flaky-bot bot opened this issue Aug 24, 2024 · 2 comments
Open

storage: TestIntegration_SoftDelete failed #10761

flaky-bot bot opened this issue Aug 24, 2024 · 2 comments
Assignees
Labels
api: storage Issues related to the Cloud Storage API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Aug 24, 2024

Note: #9781 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.


commit: ec0cbb2
buildURL: Build Status, Sponge
status: failed

@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 24, 2024
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Aug 24, 2024
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Aug 24, 2024
Copy link
Author

flaky-bot bot commented Aug 24, 2024

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (ec0cbb2), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@BrennaEpp
Copy link
Contributor

=== RUN   TestIntegration_SoftDelete/grpc
    integration_test.go:4496: HardDeleteTime of soft deleted object should be equal to SoftDeleteTime+RetentionDuration, got: 2024-09-01 07:14:01.69412 +0000 UTC, expected: 2024-09-02 07:14:01.69412 +0000 UTC
    integration_test.go:4444: delete object "soft-deleteobj-20240824-25727397791346-0058" from bucket "golang-grpc-test-20240824-25727397791346-0086": storage: object doesn't exist

Looks like the same issue as before:

This is likely due to metadata propagation delay when changing soft delete retention to 9 days instead of 8 - got time is 8 days in the future, which was the original retention policy, expected time is 9 days as was updated in L4322[this line number now likely wrong].

@BrennaEpp BrennaEpp added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants