Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recommender: v1beta1 Grpc Recommender Client lacking locations calls #10559

Open
murarustefaan opened this issue Jul 17, 2024 · 1 comment
Open
Assignees
Labels
api: recommender Issues related to the Recommender API. external This issue is blocked on a bug with the actual product. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@murarustefaan
Copy link

murarustefaan commented Jul 17, 2024

Client

Recommender GRPC

Environment

N/A

Go Environment

N/A

Code

N/A

Expected behavior

Go recommender client should have Location methods exposed in the docs.

https://pkg.go.dev/cloud.google.com/go/recommender/apiv1beta1#Client.ListRecommendations
https://cloud.google.com/recommender/docs/reference/rest/v1beta1/organizations.locations/list
https://cloud.google.com/recommender/docs/reference/rest/v1beta1/projects.locations/list
https://cloud.google.com/recommender/docs/reference/rest/v1beta1/folders.locations/list

Actual behavior

Go recommender client does not have any location methods.

Additional context

Trying to pull recommendations from all locations, but it does not make sense to waste API calls to regions that do not have recommendations at all.

I am willing to work on this if it's something I'm able to do, provided you can share some hints on where to start.

@murarustefaan murarustefaan added the triage me I really want to be triaged. label Jul 17, 2024
@product-auto-label product-auto-label bot added the api: recommender Issues related to the Recommender API. label Jul 17, 2024
@murarustefaan murarustefaan changed the title recommender: v1beta1 Recommender Client lacking locations calls recommender: v1beta1 Grpc Recommender Client lacking locations calls Jul 18, 2024
@codyoss codyoss self-assigned this Jul 24, 2024
@codyoss
Copy link
Member

codyoss commented Jul 26, 2024

Thank you for the report. I have reported this internally so we can get this fixed.

Internal Bug: 355625308

@codyoss codyoss added external This issue is blocked on a bug with the actual product. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: recommender Issues related to the Recommender API. external This issue is blocked on a bug with the actual product. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants