Skip to content

Commit

Permalink
fix(storage): check for grpc NotFound error in HMAC test (#10645)
Browse files Browse the repository at this point in the history
Co-authored-by: Chris Cotter <cjcotter@google.com>
  • Loading branch information
BrennaEpp and tritone authored Aug 7, 2024
1 parent d357a36 commit 3c8e88a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion storage/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5354,7 +5354,7 @@ func TestIntegration_HMACKey(t *testing.T) {
}

_, err = hkh.Get(ctx)
if err != nil && !strings.Contains(err.Error(), "404") {
if err != nil && !errorIsStatusCode(err, http.StatusNotFound, codes.NotFound) {
// If the deleted key has already been garbage collected, a 404 is expected.
// Other errors should cause a failure and are not expected.
t.Fatalf("Unexpected error: %v", err)
Expand Down

0 comments on commit 3c8e88a

Please sign in to comment.