Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): Add samples for backup schedule feature APIs #14720

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

aman-19
Copy link
Contributor

@aman-19 aman-19 commented Sep 19, 2024

This PR adds code samples for the following Cloud Spanner APIs:

  1. CreateBackupSchedule (both full and incremental backup schedules)
  2. ListBackupSchedules
  3. GetBackupSchedule
  4. UpdateBackupSchedule
  5. DeleteBackupSchedule

This change is Reviewable

@aman-19 aman-19 requested a review from a team as a code owner September 19, 2024 16:42
Copy link

snippet-bot bot commented Sep 19, 2024

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples. labels Sep 19, 2024
@scotthart
Copy link
Member

/gcbrun

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 13.74046% with 113 lines in your changes missing coverage. Please review.

Project coverage is 93.45%. Comparing base (f197a85) to head (2b00801).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
google/cloud/spanner/samples/samples.cc 13.74% 113 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14720      +/-   ##
==========================================
- Coverage   93.50%   93.45%   -0.06%     
==========================================
  Files        2323     2323              
  Lines      207992   208123     +131     
==========================================
+ Hits       194478   194494      +16     
- Misses      13514    13629     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

google/cloud/spanner/samples/samples.cc Outdated Show resolved Hide resolved
google/cloud/spanner/samples/samples.cc Outdated Show resolved Hide resolved
google/cloud/spanner/samples/samples.cc Outdated Show resolved Hide resolved
google/cloud/spanner/samples/samples.cc Outdated Show resolved Hide resolved
google/cloud/spanner/samples/samples.cc Outdated Show resolved Hide resolved
google/cloud/spanner/samples/samples.cc Outdated Show resolved Hide resolved
@dbolduc
Copy link
Member

dbolduc commented Sep 20, 2024

/gcbrun

@dbolduc
Copy link
Member

dbolduc commented Sep 23, 2024

Thanks! Feel free to "Squash and merge"

I think you have permissions to do this, but if not, let me know, and I can merge the PR.

@aman-19
Copy link
Contributor Author

aman-19 commented Sep 23, 2024

It seems I don't have the permission. Could you please help merging this? Thanks.

@dbolduc dbolduc merged commit 4c8c2a5 into googleapis:main Sep 23, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants