fix: catch ValueError for json.loads() #1842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohmayr
reviewed
Oct 22, 2025
google/auth/_helpers.py
Outdated
| try: | ||
| return json.loads(body_str) | ||
| except (json.JSONDecodeError, TypeError): | ||
| except (json.JSONDecodeError, TypeError, ValueError): |
Contributor
There was a problem hiding this comment.
ValueError will catch json.JSONDecodeError as well. We can remove it since we're adding a base exception.
ohmayr
previously approved these changes
Oct 24, 2025
Linchin
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
ohmayr
approved these changes
Oct 30, 2025
Linchin
added
owlbot:ignore
gcf-owl-bot
bot
removed
the
owlbot:run
Linchin
pushed a commit
that referenced
this pull request
Oct 30, 2025
🤖 I have created a release *beep* *boop* --- ## [2.42.1](v2.42.0...v2.42.1) (2025-10-30) ### Bug Fixes * Catch ValueError for json.loads() ([#1842](#1842)) ([b074cad](b074cad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see internal bug 448976223
TODO: