feat: Add trust boundary support for external accounts. #1809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def test_build_trust_boundary_lookup_url(self): | ||
| credentials = self.make_credentials() | ||
| expected_url = "https://iamcredentials.googleapis.com/v1/locations/global/workforcePools/POOL_ID/allowedLocations" |
There was a problem hiding this comment.
Add few more cases:
- rep instead of global
- different universe
There was a problem hiding this comment.
Added a test for a different universe. I'm waiting to hear from the backend team to see if they even accept a rep or if the url has to be global. Depending on the conversation, we can address it in a feature PR to make this feature more future-proof.
sai-sunder-s
previously approved these changes
Sep 23, 2025
lsirac
previously approved these changes
Sep 24, 2025
sai-sunder-s
approved these changes
Oct 6, 2025
gcf-owl-bot
bot
removed
the
owlbot:run
This was referenced Oct 15, 2025
This was referenced Oct 15, 2025
daniel-sanche
pushed a commit
that referenced
this pull request
Oct 28, 2025
🤖 I have created a release *beep* *boop* --- ## [2.42.0](v2.41.1...v2.42.0) (2025-10-24) ### Features * Add trust boundary support for external accounts. ([#1809](#1809)) ([36ecb1d](36ecb1d)) ### Bug Fixes * Read scopes from ADC json for impersoanted cred ([#1820](#1820)) ([62c0fc8](62c0fc8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the trust boundary feature for external accounts (workforce and workload pool identity, and also authorized user)
Note: The design has changed since the first PR that implemented trust boundary for service accounts, and we are no longer required to send the allowed locations header to IAM or STS requests, only to the google API calls. You can review the most up to date design here: go/trust-boundaries-auth-sdk-v2