feat: Adds support for custom suppliers in AWS and Identity Pool credentials#1496
Merged
feat: Adds support for custom suppliers in AWS and Identity Pool credentials#1496
Conversation
…ential instantiation (#1494) * feat: refactor aws and identity pool credentials to use supplier framework * Linting * changing class types * linting * remove unused import * Fix typing * add docstring and fix casing * feat: adds support for passing suppliers to credentials. * fixes merge issues and adds _has_custom_supplier method * adds _has_custom_supplier function to identity_pool * Update google/auth/external_account.py Co-authored-by: Carl Lundin <108372512+clundin25@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Carl Lundin <108372512+clundin25@users.noreply.github.com> * Respond to comments and fix docs --------- Co-authored-by: Carl Lundin <108372512+clundin25@users.noreply.github.com>
* docs: update docs for programmatic * add space * update user guide
clundin25
reviewed
Mar 14, 2024
clundin25
reviewed
Mar 14, 2024
clundin25
approved these changes
Mar 14, 2024
clundin25
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
lsirac
requested changes
Mar 14, 2024
Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>
lsirac
approved these changes
Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features from #1494 and #1484, also adds documentation.