Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove deprecated OOB code #264

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

sai-sunder-s
Copy link
Contributor

@sai-sunder-s sai-sunder-s commented Jan 25, 2023

Removes obsolete OOB related code. BREAKING CHANGE: We have removed OOB support and related code from the library because the feature is not supported by Google OAuth as of October 3rd 2022. See the official announcement for more information.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

BEGIN_COMMIT_OVERRIDE
fix: Remove deprecated OOB code

Release-As: 1.0.0
END_COMMIT_OVERRIDE

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jan 25, 2023
@sai-sunder-s sai-sunder-s marked this pull request as ready for review January 26, 2023 00:56
@sai-sunder-s sai-sunder-s requested review from a team as code owners January 26, 2023 00:56
@sai-sunder-s sai-sunder-s added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 26, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 26, 2023
@sai-sunder-s sai-sunder-s merged commit 1391486 into googleapis:main Jan 26, 2023
@parthea parthea added the release-please:force-run To run release-please label Jan 26, 2023
@release-please release-please bot removed the release-please:force-run To run release-please label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants