Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check CLOUDSDK_CONFIG for default credentials location #58

Closed
ajkannan opened this issue Feb 28, 2016 · 4 comments
Closed

Check CLOUDSDK_CONFIG for default credentials location #58

ajkannan opened this issue Feb 28, 2016 · 4 comments
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@ajkannan
Copy link

In DefaultCredentialsProvider.getWellKnownCredentialsFile(), the environment variable CLOUDSDK_CONFIG isn't checked. Instead, it assumes that the .config directory is in home. If the CLOUDSDK_CONFIG environment variable is set, that should be used instead of home. This would be consistent with the issue reported in the python equivalent of this library (see this issue).

As a result of not checking CLOUDSDK_CONFIG, users can see the issues like this if they install Cloud SDK in a non-default location.

@aozarov
Copy link

aozarov commented Apr 4, 2016

ping. /cc @anthmgoogle

@aozarov aozarov added the bug label Apr 4, 2016
@anthmgoogle
Copy link
Contributor

@lesv @ejona86. Agree this is a bug that should be fixed.

@lesv lesv self-assigned this Apr 28, 2016
@lesv
Copy link
Contributor

lesv commented Apr 28, 2016

I'll try to go through all of these issues next week.

@mziccard
Copy link
Contributor

mziccard commented Nov 3, 2016

I believe this was fixed in #63

@mziccard mziccard closed this as completed Nov 3, 2016
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

6 participants