fix: module names can no longer collide with keywords or builtins #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
software-dov
requested review from
lukesneeringer,
crwilcox,
busunkim96 and
arithmetic1728
google-cla
bot
added
the
cla: yes
busunkim96
approved these changes
Sep 15, 2020
arithmetic1728
approved these changes
Sep 15, 2020
E.g. protobuf/any.proto will be imported as from google.protobuf import any_pb2 as gp_any # Was previously 'as any'
software-dov
force-pushed
the
builtins
branch
from
e17d88e
to
d9174bb
Compare
software-dov
force-pushed
the
builtins
branch
from
d9174bb
to
e904920
Compare
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1519 1525 +6
Branches 309 309
=========================================
+ Hits 1519 1525 +6
Continue to review full report at Codecov.
|
This was referenced Oct 12, 2020
tswast
pushed a commit
to googleapis/python-bigquery-datatransfer
that referenced
this pull request
Oct 13, 2020
…ty to type_ (#53) BREAKING CHANGE: type is renamed to type_ to avoid conflict with built-in functions (introduced in googleapis/gapic-generator-python#595) * changes without context autosynth cannot find the source of changes triggered by earlier changes in this repository, or by version upgrades to tools such as linters. * chore(python): use BUILD_SPECIFIC_GCLOUD_PROJECT for samples https://github.com/googleapis/python-talent/blob/ef045e8eb348db36d7a2a611e6f26b11530d273b/samples/snippets/noxfile_config.py#L27-L32 `BUILD_SPECIFIC_GCLOUD_PROJECT` is an alternate project used for sample tests that do poorly with concurrent runs on the same project. Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Wed Sep 30 13:06:03 2020 -0600 Source-Repo: googleapis/synthtool Source-Sha: 9b0da5204ab90bcc36f8cd4e5689eff1a54cc3e4 Source-Link: googleapis/synthtool@9b0da52 Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Sep 22, 2023
…ty to type_ (#53) BREAKING CHANGE: type is renamed to type_ to avoid conflict with built-in functions (introduced in googleapis/gapic-generator-python#595) * changes without context autosynth cannot find the source of changes triggered by earlier changes in this repository, or by version upgrades to tools such as linters. * chore(python): use BUILD_SPECIFIC_GCLOUD_PROJECT for samples https://github.com/googleapis/python-talent/blob/ef045e8eb348db36d7a2a611e6f26b11530d273b/samples/snippets/noxfile_config.py#L27-L32 `BUILD_SPECIFIC_GCLOUD_PROJECT` is an alternate project used for sample tests that do poorly with concurrent runs on the same project. Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Wed Sep 30 13:06:03 2020 -0600 Source-Repo: googleapis/synthtool Source-Sha: 9b0da5204ab90bcc36f8cd4e5689eff1a54cc3e4 Source-Link: googleapis/synthtool@9b0da52 Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. protobuf/any.proto will be imported as
from google.protobuf import any_pb2 as gp_any # Was previously 'as any'