-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add oneof fields to generated protoplus init #485
Conversation
It seems perhaps the data for oneofs may not be captured? The template ought to be right provided oneof makes it to the field. gapic-generator-python/gapic/schema/api.py Line 471 in 920e419
gapic-generator-python/gapic/schema/api.py Line 782 in 920e419
|
@BenRKarl For sure. Thanks for pointing that out. Still need to figure out piping the oneof data down to the field I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can't wait to see the additional tests.
…/gapic-generator-python into oneof-proto-templates
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1466 1487 +21
Branches 300 303 +3
=========================================
+ Hits 1466 1487 +21
Continue to review full report at Codecov.
|
Fixes: #484