Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of exceptions in retries.if_exception_type is unstable #617

Closed
busunkim96 opened this issue Sep 23, 2020 · 0 comments · Fixed by #619
Closed

Order of exceptions in retries.if_exception_type is unstable #617

busunkim96 opened this issue Sep 23, 2020 · 0 comments · Fixed by #619
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@busunkim96
Copy link
Contributor

See https://github.com/googleapis/python-firestore/pull/197/files/ for an example.

The exceptions do not seem to get consistently sorted in alphabetical order.

The fluctuating order shows up in the three files with this clause.

predicate=retries.if_exception_type(
{%- filter sort_lines %}
{%- for ex in method.retry.retryable_exceptions %}
exceptions.{{ ex.__name__ }},
{%- endfor %}
{%- endfilter %}
),

@busunkim96 busunkim96 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 23, 2020
tseaver added a commit to googleapis/python-firestore that referenced this issue Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
2 participants