Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create helper methods for file-level resources #255

Closed
software-dov opened this issue Dec 5, 2019 · 2 comments
Closed

Create helper methods for file-level resources #255

software-dov opened this issue Dec 5, 2019 · 2 comments
Assignees
@software-dov
Labels
generator Bugs, features, and so forth pertaining to the generated client surface priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@software-dov
Copy link
Contributor

Proto annotations allows for resources to be described at the file level instead of being a method option.

E.g.

// Define a "User" resource owned by OS Login.
option (google.api.resource_definition) = {
  type: "oslogin.googleapis.com/User"
  pattern: "users/{user}"
};

These resources also need generated helper methods.
@software-dov software-dov added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. generator Bugs, features, and so forth pertaining to the generated client surface labels Dec 5, 2019
@software-dov software-dov self-assigned this Dec 5, 2019
@software-dov software-dov mentioned this issue Dec 18, 2019
Closed
@software-dov
Copy link
Contributor Author

See below for additional details
https://github.com/googleapis/googleapis/blob/d9576d95b44f64fb0e3da4760adfc4a24fa1faab/google/api/resource.proto#L35-L39

@software-dov software-dov added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Mar 9, 2020
@software-dov
Copy link
Contributor Author

Closed by #642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@software-dov software-dov

Labels
generator Bugs, features, and so forth pertaining to the generated client surface priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@software-dov