Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protobuf docstrings wrap links midway if they contain dashes #1131

Closed
tswast opened this issue Jan 13, 2022 · 0 comments · Fixed by #1140 or #1163
Closed

Protobuf docstrings wrap links midway if they contain dashes #1131

tswast opened this issue Jan 13, 2022 · 0 comments · Fixed by #1140 or #1163
Assignees
@parthea
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tswast
Copy link

tswast commented Jan 13, 2022

See: googleapis/python-bigquery-datatransfer#266 and googleapis/python-bigquery-datatransfer@fae2290
@tswast tswast added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 13, 2022
@tswast tswast mentioned this issue Jan 13, 2022
Merged
4 tasks
@parthea parthea self-assigned this Jan 20, 2022
@parthea parthea mentioned this issue Jan 20, 2022
Merged
software-dov pushed a commit that referenced this issue Jan 25, 2022
@parthea
fix: preserve hyperlinks with hyphens (#1140)
b091bfc 
The default behaviour of textwrap.wrap is to break text on hyphens. This PR sets the break_on_hyphens parameter of textwrap.wrap to False in order to preserve hyperlinks with hyphens.

Fixes #1131
This was referenced Jan 25, 2022
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
2 participants
@tswast @parthea