Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy reports typing for retry arguments is invalid #1024

Closed
tseaver opened this issue Oct 13, 2021 · 0 comments · Fixed by #1026
Closed

mypy reports typing for retry arguments is invalid #1024

tseaver opened this issue Oct 13, 2021 · 0 comments · Fixed by #1026
Assignees
@tseaver
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tseaver
Copy link
Contributor

tseaver commented Oct 13, 2021

E.g., from datastore:

google/cloud/datastore_v1/services/datastore/client.py:331: error: Incompatible default for argument "retry" (default has type "object", argument has type "Retry")
@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 13, 2021
@tseaver tseaver self-assigned this Oct 13, 2021
tseaver added a commit that referenced this issue Oct 13, 2021
@tseaver
fix: use correct typing for retries
29a8d02 
fix: import 'ClientOptions' class correctly

Closes #1024
Closes #1025
@tseaver tseaver mentioned this issue Oct 13, 2021
Merged
tseaver added a commit that referenced this issue Oct 13, 2021
@tseaver
fix: use correct typing for retries
67634ad 
fix: import 'ClientOptions' class correctly

Closes #1024
Closes #1025
tseaver added a commit that referenced this issue Oct 13, 2021
@tseaver
fix: use correct typing for retries / operations_client (#1026)
acb3ea8 
* fix: use correct typing for retries

Closes #1024

* fix: import 'ClientOptions' class correctly

Closes #1025

* fix: remove typing from base transport 'operations_client', repair typing for `_operations_client` attr

Closes #1028.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use correct typing for retries googleapis/gapic-generator-python
1 participant
@tseaver