Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed not writing specs to directory #10

Closed
wants to merge 4 commits into from

Conversation

iamwilhelm
Copy link

The code had problems at every stage:

Fetching stage

During fetching, it wasn't writing anything to the directory, because it was trying to write a keymap to file, instead of a string.

Also, the key for the spec listings in the discovery file changed from url to discoveryRestUrl.

I changed the with statements to case, just so I could get it working, and I understood it. Uglier, but it works.

Conversion stage

Similar problem as fetching, but it wasn't writing, because the directory openapi had never been created

Build stage

Just had to state what the current docker image should be.

However, had a question here...once I generated the client, it had all these new empty files that were generated. Is that suppose to happen?

It wasn’t writing before, because body was 
{body, “default”}, which is a keymap, and not a
string. And the with statement didn’t have the
mechanism to report what was wrong.
That’s because it needed the openapi directory
to exist, and it wasn’t already created.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@chingor13
Copy link
Contributor

chingor13 commented Sep 26, 2017

Thanks for the PR!

For fetching, the 404s will go away when I remove the APIs that should not be there.

For converting, we should ensure that the openapi directory exists, or create it. (Created #12)

For generating the client, you are getting empty files and not the latest generated code as we are using the fork from the pending PR to swagger-codegen (so it's not in the master image).

@chingor13 chingor13 closed this Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants