Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint failing due to missing mypy types #73

Closed
tbpg opened this issue Jun 17, 2021 · 3 comments · Fixed by #74
Closed

Lint failing due to missing mypy types #73

tbpg opened this issue Jun 17, 2021 · 3 comments · Fixed by #74
Assignees
@tbpg
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tbpg
Copy link
Collaborator

tbpg commented Jun 17, 2021 

nox > mypy docuploader
docuploader/__main__.py:24: error: Library stubs not installed for "pkg_resources" (or incompatible with Python 3.6)
docuploader/__main__.py:24: note: Hint: "python3 -m pip install types-pkg_resources"
docuploader/__main__.py:24: note: (or run "mypy --install-types" to install all missing stub packages)
docuploader/__main__.py:24: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 1 error in 1 file (checked 9 source files)
@tbpg tbpg added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 17, 2021
@tbpg tbpg self-assigned this Jun 17, 2021
@tbpg
Copy link
Collaborator Author

tbpg commented Jun 17, 2021

See https://source.cloud.google.com/results/invocations/ea8521fd-882d-40ca-b222-4f45ee4fdd64/targets/cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fdocuploader%2Fcontinuous%2Fcontinuous/log.

@busunkim96 is this something we need to fix in the base image?

@parthea parthea mentioned this issue Jun 17, 2021
Merged
@parthea
Copy link
Contributor

parthea commented Jun 17, 2021

Hi @tbpg ,

I have a fix in #74. Please can you take a look?

@tbpg
Copy link
Collaborator Author

tbpg commented Jun 17, 2021

Thank you, @parthea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbpg tbpg

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Use python 3.8 by default in noxfile googleapis/docuploader
2 participants
@parthea @tbpg